Bug 159767 – When accessing "Edit->toolbars" epi crash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 159767 - When accessing "Edit->toolbars" epi crash


Summary:	When accessing "Edit->toolbars" epi crash


Status:	RESOLVED FIXED

Product:	epiphany
Classification:	Core
Component:	Controls
Version:	unspecified
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	1.6
Assigned To:	Epiphany Maintainers
QA Contact:	Marco Pesenti Gritti

URL:
Whiteboard:

Duplicates:	168865 170121 304618 (view as bug list)
Depends on:
Blocks:

Reported:	2004-11-28 22:02 UTC by Baptiste Mille-Mathias
Modified:	2005-05-22 10:45 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
possible fix, copied from bug 152490 (785 bytes, patch) 2005-04-19 21:10 UTC, Christian Persch	committed	Details \| Review

Description Baptiste Mille-Mathias 2004-11-28 22:02:46 UTC

Each type I click "Edit -> Toolbars", Epiphany crashes.
The backend used is Firefox

Find below the backtrace
========================
Program received signal SIGTRAP, Trace/breakpoint trap.

+ Trace 52832

Thread 1091056160 (LWP 7910)

#0 g_logv
from /usr/lib/libglib-2.0.so.0
#1 g_log
from /usr/lib/libglib-2.0.so.0
#2 _gdk_windowing_exit
from /usr/lib/libgdk-x11-2.0.so.0
#3 bonobo_ui_gtk_module_info_get
from /usr/lib/libbonoboui-2.so.0
#4 _XError
from /usr/X11R6/lib/libX11.so.6
#5 _XReply
from /usr/X11R6/lib/libX11.so.6
#6 XGetGeometry
from /usr/X11R6/lib/libX11.so.6
#7 gdk_window_get_geometry
from /usr/lib/libgdk-x11-2.0.so.0
#8 gdk_screen_get_monitor_at_window
from /usr/lib/libgdk-x11-2.0.so.0
#9 _gtk_window_unset_focus_and_default
from /usr/lib/libgtk-x11-2.0.so.0
#10 gtk_window_reshow_with_initial_size
from /usr/lib/libgtk-x11-2.0.so.0
#11 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#12 g_cclosure_new_swap
from /usr/lib/libgobject-2.0.so.0
#13 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#14 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#15 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#16 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#17 gtk_widget_show
from /usr/lib/libgtk-x11-2.0.so.0
#18 window_cmd_edit_toolbar
#19 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#20 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#21 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#22 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#23 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#24 _gtk_action_emit_activate
from /usr/lib/libgtk-x11-2.0.so.0
#25 gtk_action_activate
from /usr/lib/libgtk-x11-2.0.so.0
#26 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#27 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#28 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#29 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#30 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#31 gtk_widget_activate
from /usr/lib/libgtk-x11-2.0.so.0
#32 gtk_menu_shell_activate_item
from /usr/lib/libgtk-x11-2.0.so.0
#33 _gtk_menu_shell_activate
from /usr/lib/libgtk-x11-2.0.so.0
#34 gtk_menu_reorder_child
from /usr/lib/libgtk-x11-2.0.so.0
#35 _gtk_marshal_BOOLEAN__BOXED
from /usr/lib/libgtk-x11-2.0.so.0
#36 g_cclosure_new_swap
from /usr/lib/libgobject-2.0.so.0
#37 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#38 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#39 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#40 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#41 gtk_widget_send_expose
from /usr/lib/libgtk-x11-2.0.so.0
#42 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#43 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#44 _gdk_events_queue
from /usr/lib/libgdk-x11-2.0.so.0
#45 g_main_depth
from /usr/lib/libglib-2.0.so.0
#46 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#47 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#48 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#49 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#50 main

Comment 1 Christian Persch 2004-11-28 22:28:01 UTC

Do you have the composite X extension enabled (-> bug 150259) ?

Comment 2 Christian Persch 2004-11-28 22:30:17 UTC

Also, are there any warnings on console ?

Comment 3 Baptiste Mille-Mathias 2004-11-28 22:55:44 UTC

Hello Christian,

Yes the X extension composite is enable.
after I set the variable XLIB_SKIP_ARGB_VISUALS=1 I saw some output like 

(epiphany:8203): Gdk-CRITICAL **: gdk_drawable_set_colormap: assertion `cmap ==
NULL || gdk_drawable_get_depth (drawable) == cmap->visual->depth' failed
(epiphany:8203): Gdk-WARNING **: gdkpixbuf-drawable.c:1249: Source drawable has
no colormap; either pass in a colormap, or set the colormap on the drawable with
gdk_drawable_set_colormap()
(epiphany:8203): Gdk-CRITICAL **: gdk_drawable_set_colormap: assertion `cmap ==
NULL || gdk_drawable_get_depth (drawable) == cmap->visual->depth' failed

Comment 4 Christian Persch 2004-12-07 13:46:29 UTC

No epiphany code involved; only gtk+ symbols. Re-assigning to gtk+.

Comment 5 Owen Taylor 2004-12-18 14:44:35 UTC

I would assume, unless proven otherwise, that this is a colormap 
mismatch caused by Epiphany resulting in a BadMatch ... back-traces
for X errors when the app isn't run with --sync don't tell you
anything.

Comment 6 Christian Persch 2004-12-18 16:56:18 UTC

First, a trace from the warning:
(epiphany:1450): Gdk-CRITICAL **: gdk_drawable_set_colormap: assertion `cmap ==
NULL || gdk_drawable_get_depth (drawable) == cmap->visua
l->depth' failed

Program received signal SIGTRAP, Trace/breakpoint trap.

+ Trace 53659

Thread NaN (LWP 1450)

#0 trap_handler
#1 g_logv
at gmessages.c line 469
#2 g_log
at gmessages.c line 507
#3 g_return_if_fail_warning
#4 gdk_drawable_set_colormap
at gdkdraw.c line 271
#5 update_separator_image
at ../../../lib/egg/egg-editable-toolbar.c line 1405
#6 _egg_editable_toolbar_new_separator_image
at ../../../lib/egg/egg-editable-toolbar.c line 1455
#7 update_editor_sheet
at ../../../lib/egg/egg-toolbar-editor.c line 555
#8 window_cmd_edit_toolbar
at ../../src/window-commands.c line 839
#0 gdk_x_error
at gdkmain-x11.c line 505
#1 bonobo_x_error_handler
at bonobo-ui-main.c line 50
#2 _XError
from /usr/X11R6/lib/libX11.so.6
#3 _XReply
from /usr/X11R6/lib/libX11.so.6
#4 XSync
from /usr/X11R6/lib/libX11.so.6
#5 XSync
from /usr/X11R6/lib/libX11.so.6
#6 XFillRectangle
from /usr/X11R6/lib/libX11.so.6
#7 gdk_x11_draw_rectangle
at gdkdrawable-x11.c line 468
#8 gdk_draw_rectangle
at gdkdraw.c line 434
#9 gdk_pixmap_draw_rectangle
at gdkpixmap.c line 260
#10 gdk_draw_rectangle
at gdkdraw.c line 434
#11 gtk_default_draw_flat_box
at gtkstyle.c line 3743
#12 gtk_paint_flat_box
at gtkstyle.c line 6116
#13 gtk_window_paint
at gtkwindow.c line 5780
#14 gtk_window_expose
at gtkwindow.c line 5789
#15 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 83
#16 g_type_class_meta_marshal
at gclosure.c line 514
#17 g_closure_invoke
at gclosure.c line 437
#18 signal_emit_unlocked_R
at gsignal.c line 2523
#19 g_signal_emit_valist
at gsignal.c line 2254
#20 g_signal_emit
at gsignal.c line 2288
#21 gtk_widget_event_internal
at gtkwidget.c line 3616
#22 fake_expose_widget
at ../../../lib/egg/egg-editable-toolbar.c line 1347
#23 update_separator_image
at ../../../lib/egg/egg-editable-toolbar.c line 1412
#24 _egg_editable_toolbar_new_separator_image
at ../../../lib/egg/egg-editable-toolbar.c line 1455
#25 update_editor_sheet
at ../../../lib/egg/egg-toolbar-editor.c line 555
#26 window_cmd_edit_toolbar
at ../../src/window-commands.c line 839

Comment 7 Christian Persch 2004-12-24 20:42:55 UTC

Reporter: does the "Theme" applet in GNOME Control Centre work with composite
enabled? (the crashing code is copied from there)

Comment 8 Sebastien Bacher 2004-12-24 23:48:35 UTC

nop, the previews crash with the composite:
http://bugzilla.gnome.org/show_bug.cgi?id=152490

Comment 9 Christian Persch 2004-12-26 19:03:03 UTC

I see. The code for creating the separator toolitem image is copied from there,
so this is probably the same problem as bug 152490.

/me wait for them to fix it... ;)

Comment 10 Christian Persch 2005-03-01 11:49:21 UTC

*** Bug 168865 has been marked as a duplicate of this bug. ***

Comment 11 Christian Persch 2005-03-13 10:37:24 UTC

*** Bug 170121 has been marked as a duplicate of this bug. ***

Comment 12 Christian Persch 2005-04-19 21:10:59 UTC

Created attachment 45460 [details] [review]
possible fix, copied from bug 152490

Can someone who uses X composite extension and compiles Epiphany from source
please test this patch? Thanks.

Comment 13 Christian Persch 2005-04-26 12:16:58 UTC

I committed this patch to gnome-2-10 and HEAD. If the bug still happens, please
re-open this bug report.

Comment 14 Baptiste Mille-Mathias 2005-05-18 19:29:00 UTC

*** Bug 304618 has been marked as a duplicate of this bug. ***

Comment 15 Marco Pesenti Gritti 2005-05-22 10:45:20 UTC

I'm committing this to libegg... Let's try to keep it in sync!