After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158566 - Print preview leak
Print preview leak
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Printing
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-11-17 19:03 UTC by Morten Welinder
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Morten Welinder 2004-11-17 19:03:18 UTC
Here's the leak that triggers the value pool leak.


--- print.c.~1.167.~	2004-10-19 15:54:05.000000000 -0400
+++ print.c	2004-11-17 13:58:35.000000000 -0500
@@ -1403,7 +1403,7 @@
 sheet_print (WorkbookControlGUI *wbcg, Sheet *sheet,
 	     gboolean preview, PrintRange default_range)
 {
-	PrintJobInfo *pj = NULL;
+	PrintJobInfo *pj;
 	GtkWidget *gnome_print_dialog = NULL;
 	PrintDialogState *state = NULL;
 
@@ -1419,6 +1419,7 @@
 
 	if (preview) {
 		sheet_print_real (wbcg, sheet, TRUE, pj, default_range);
+		print_job_info_destroy (pj);
 		return;
 	}
Comment 1 Jody Goldberg 2004-11-18 16:06:52 UTC
This looks safe.  Pleae commit.
Comment 2 Morten Welinder 2004-11-18 16:10:56 UTC
Committed.