After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155425 - Correctly interpret various artist data from FreeDB via MB
Correctly interpret various artist data from FreeDB via MB
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: metadata
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 158167 310955 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-14 20:33 UTC by Sebastien Bacher
Modified: 2005-11-23 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sj-better-import-from-freedb.patch (1.73 KB, patch)
2005-08-21 11:17 UTC, Bastien Nocera
none Details | Review

Description Sebastien Bacher 2004-10-14 20:33:21 UTC
this bug has been reported here: https://bugzilla.ubuntu.com/2125

"I used to use abcde before Ubuntu, which had the nice feature that if the
artist name from the online database was "Various" or similar, and the track
title had a " - " or / in the name, then it'd try to split the track name into
artist and title, giving the user the choice over whether the ordering was
Artist / Title or Title / Artist."
Comment 1 Ross Burton 2004-10-15 08:22:33 UTC
In theory this isn't required in SJ as MusicBrainz says that tracks have artists
instead of albums having artists.  Thus for a compilation the album artist is
"Various" but the track artists are correct for each track, and for mix albums
the album artist is the mixer and the track artist is correct.

If there are any albums which don't do this correctly on Musicbrainz, the data
should be fixed instead of all clients working around it.
Comment 2 Ross Burton 2005-02-06 17:53:02 UTC
*** Bug 158167 has been marked as a duplicate of this bug. ***
Comment 3 Hidde Brugmans 2005-06-15 14:09:51 UTC
Personally I have worked around this by setting the album artist to various, and
renaming all tracks to "artist - title.flac"
This seems to be the only way that I can avoid getting a mess of artist names in
rhythmbox
Comment 4 Ross Burton 2005-07-28 08:36:07 UTC
*** Bug 310955 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2005-08-21 11:15:46 UTC
"If there are any albums which don't do this correctly on Musicbrainz, the data
should be fixed instead of all clients working around it."

Getting the data fixed is not trivial. Sound-juicer has no direct link to
Musicbrainz in its UI for users to go and fix the data, and AFAICS, no
documentation on it either.

I'm attaching a patch that takes the pain away from renaming all the tracks when
the data from Musicbrainz is "broken".
Comment 6 Bastien Nocera 2005-08-21 11:17:11 UTC
Created attachment 51056 [details] [review]
sj-better-import-from-freedb.patch

For some reason, album->artist_id and track->artist_id end up empty instead of
containing MBI_VARIOUS_ARTIST_ID.
Comment 7 David Mandelberg 2005-10-05 19:06:46 UTC
Doesn't SJ default to FreeDB is the cdid isn't found on MB? If it does and it
gets the metadata from FreeDB, this would be a good idea.
Comment 8 Ross Burton 2005-10-06 07:14:39 UTC
As said before, Musicbrainz will fetch itselfs from FreeDB if it doesn't have
the data.  I'll be applying this shortly.
Comment 9 Ross Burton 2005-11-23 09:31:30 UTC
Committed to HEAD, thanks!