GNOME Bugzilla – Bug 137952
Missing file filters on gpdf choosers
Last modified: 2009-08-15 18:40:50 UTC
No way to filter PDF documents exists when loading or saving in gpdf. May I commit?
Created attachment 25886 [details] [review] Add filters 'pdf'/'*.*' to both choosers in gpdf
Created attachment 25888 [details] [review] this is the good patch
Looks good except: * "*.*" should be "*", no reason to require at least on dot. * It adds two strings, thus requires permission from translators. But it should definitely be included in GNOME 2.6.1. I'd like to use the delay of 2.6.0 to make another tarball for 2.6.0 which includes the (at least) two new translations which were added since gpdf 0.130. Thus gpdf is still in code freeze until Monday. Then we can get the permission from gnome-i18n and you can check in.
Yes agreed
Can you commit a patch where the filter names _don't_ have to be translated, but are simply "PDF" and "*" (and without _())? That will save us from asking for permission from i18n. (But if you forget to remove the _(), we'll be blamed publically on desktop-devel-list ;)) Don't close the bug to remind us to make the names translatable when gpdf is branched. I want to try to fix some crashers for stable before branching.
*** Bug 140429 has been marked as a duplicate of this bug. ***
Martin may I commit now ?
Yes, please commit to HEAD. If you want to commit to gnome-2-6 branch, too, do what I wrote in comment #5. Reassigned to you, so you can close the bug after committing.
commited: 2004-05-03 Remi Cohen-Scali <rcoscali@cvs.gnome.org> Fix for Bug #137952. * xpdf/gpdf-control.cc (gpdf_control_get_filename) Added file filters 'application/pdf' and '*' to file choosers. * shell/gpdf.c (gw_ask_for_uri): Fixed badly updated *.* in filter (must be *) * shell/gpdf.c (gw_ask_for_uri): Added file filters 'application/pdf' and '*.*' to file choosers.
Also commited to gnome-2-6 branch.
Verified on HEAD
Also verified on gnome-2-6. Closing bug.
Committing this on the gnome-2-6 branch broke the string freeze in effect on that branch. The string freeze is still in effect for GNOME 2.6 software. Thus you still need to announce and ask for permission on string changes!
I'am sorry. I was about to send a warn on i18n list, but I looked at the shedule and I thought 2.6.1 was released. Again please apologize !
Christian wrote: "Still, the patch and these additions look like they could be useful and needed, so offhand I'm not requesting they be reverted." Now 7 translations have already been updated. Should the patch be reverted or not? I had that "PDF" and "*" (not beautiful UI but functional and not string-freeze breaking) idea somewhere above. Doing that now means throwing the 7's work away. How about this: I put "PDF" and "*" as "translations" into the po files of all po files except those 7?
The patch need not reverting. I've approved it from a string freeze perspective afterwards, after it was committed without notice. This is NOT the way it is supposed to be, but the patch looked needed. So *no* changes in translatable strings from now on is needed, or at all wanted, from a string freeze perspective.