After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125452 - attempt to detect recursive symlink loops
attempt to detect recursive symlink loops
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 127290 129304 136560 139689 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-10-24 22:49 UTC by Spundun Bhatt
Modified: 2006-01-17 02:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.23 KB, patch)
2006-01-15 11:47 UTC, James "Doc" Livingston
committed Details | Review

Description Spundun Bhatt 2003-10-24 22:49:16 UTC
The problem (as I told walters yesterday on irc) is this:

When rhythm box is searching for media in a folder tree, if that tree has
cycles caused by symbolic links, then the scanning might never end.

In this case either rhythmbox needs to detect these loops or they should
provide a "stop scanning" menu item, so that if a user runs into this
problem by mistake, he can atleast stop it, without killing the rhythmbox
application.

I tend to put symlinks to other ppls home directories in my home directory,  :)
hope this helps
Spundun
Comment 1 Colin Walters 2003-11-18 15:28:57 UTC
*** Bug 127290 has been marked as a duplicate of this bug. ***
Comment 2 Colin Walters 2003-12-14 13:44:29 UTC
*** Bug 129304 has been marked as a duplicate of this bug. ***
Comment 3 Colin Walters 2004-03-08 19:25:27 UTC
*** Bug 136560 has been marked as a duplicate of this bug. ***
Comment 4 Colin Walters 2004-04-13 20:59:44 UTC
*** Bug 139689 has been marked as a duplicate of this bug. ***
Comment 5 Loïc Minier 2004-10-13 16:19:34 UTC
This is Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=238706
Comment 6 James "Doc" Livingston 2006-01-15 11:47:44 UTC
Created attachment 57399 [details] [review]
patch

This patch changes rb_uri_handle_recursively to use gnome_vfs_directory_visit, which has in-built support for detecting symlink loops.
Comment 7 Bastien Nocera 2006-01-15 13:58:04 UTC
Might want to fix the typo in the function name :)
+rb_uri_handle_recursvely_cb
Comment 8 James "Doc" Livingston 2006-01-17 02:16:48 UTC
Committed to cvs (with the spelling fix).