After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 123372 - Revert WM accessibility module loading in GNOME 2.6
Revert WM accessibility module loading in GNOME 2.6
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on: 117236
Blocks:
 
 
Reported: 2003-09-27 15:18 UTC by Havoc Pennington
Modified: 2006-05-15 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert the patch from bug #120025 (4.83 KB, patch)
2006-05-03 22:17 UTC, Elijah Newren 		committed Details | Review

Description Havoc Pennington 2003-09-27 15:18:09 UTC 
For GNOME 2.4 we added an emergency patch found in bug #120025 to read 
the /desktop/gnome gconf key and load accessibility GTK modules.

For GNOME 2.6 we will remove this patch. The equivalent patch should also
come out of libgnome in 2.6. Which means bug #117236 needs to be closed 
in GTK+ 2.4.

In any case, this bug is a tracker to remove the metacity patch.

Doing this properly will mean that any app linked to GTK+ is accessible
automatically, while right now only apps linking to libgnome are accessible.
Comment 1 bill.haneman 2003-09-29 10:42:55 UTC 
added 'WM' to summary since in a multi-component list it wasn't
apparent that this was metacity-specific
Comment 2 Havoc Pennington 2003-09-29 16:14:51 UTC 
Though libgnome should be fixed too ;-)
Comment 3 Havoc Pennington 2003-12-07 21:24:49 UTC 
Should probably be marked as an a11y priority along with bug #117236
Comment 4 Havoc Pennington 2003-12-07 21:26:50 UTC 
Hmm, really 117236 is the a11y priority, we could just go ahead and
remove the metacity hack right away to be sure the bug is visible and
not masked.
Comment 5 bill.haneman 2003-12-08 11:01:13 UTC 
I'd prefer not removing the hack until the alternative is in place,
since it would block lots of testing/eval (HEAD is being used by
assistive technology users and testers at this time).
Comment 6 Havoc Pennington 2004-04-13 00:18:24 UTC 
As long as bug #117236 appears to be moving (or blocking on Owen rather than the
a11y team) then I guess I have to leave the hack there ;-)

It'd be good to fix this sooner rather than later in the GTK 2.6 cycle though.
Comment 7 Elijah Newren 2005-10-07 16:08:36 UTC 
Remove old target milestones on old bugs; sorry for the spam.
Comment 8 Elijah Newren 2006-05-03 22:16:30 UTC 
This gtk+ bug was fixed by Matthias/Alex as of 2004-09-31.  I'll attach a patch in a minute to revert the changes from bug 120025.  I'd appreciate tests/comments from the accessibility people and Havoc as to whether the patch is right and all that's needed.  If I get none, I'll just commit and see if anyone screems.  ;-)
Comment 9 Elijah Newren 2006-05-03 22:17:26 UTC 
Created attachment 64773 [details] [review]
Revert the patch from bug #120025
Comment 10 Elijah Newren 2006-05-15 18:46:35 UTC 
Okay, going the commit-it-and-see-if-anyone-screams route.  I'm not very sure about reverting the src/tabpopup.c parts of the changes, but hey, this is probably the best way to get feedback on whether it's right or not.  ;-)