GNOME Bugzilla – Bug 118049
Please use ngettext for handling plurals in gnome-vfs
Last modified: 2004-12-22 21:47:04 UTC
Please see this page which describes the issue in more detail: http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals This are the incorrect strings: #: libgnomevfs/gnome-vfs-utils.c:84 msgid "1 byte" #: libgnomevfs/gnome-vfs-utils.c:86 #, c-format msgid "%u bytes" I'll attach a simple patch to fix this.
Adding a "this bug blocks 116236" according to Christian's suggestion.
Created attachment 18515 [details] [review] Use ngettext to provide plural-forms
Will that work on Solaris, AIX, HP/UX or whatever? Does that require GNU/Gettext? Is GNU/Gettext a requirement for building GNOME ? Feel free to commit if the answers to these questions are 'yes'.
I committed your patch, but I'd feel more comfortable about it if someone could certify me that there is a gnome module (intltool or glib for example) which checks if ngettext is available and doesn't compile if it's not there...
CCing Christian because he's the "official" person to ask about these issues. This was discussed in some other bugs, and reportedly, it was decided at GUADEC that this was The Right Thing. Also, see a bug 116236 ("bug 118049 blocks..."), where all of this should be finally decided before 2.4 release.
The patch has been reverted since it opens a whole can of worms, it's probably better to wait until 2.6 for that
I believe that's fine, but you should first announce that on gnome-i18n because this is going to break a string freeze -- at least it seems so to me. (In any case, that patch is included just to indicate that it's a trivial fix, so whenever it is decided to "go for it", it should be a simple matter of going through 116236 and closing all the bugs -- alas, string freeze time is not a right time for it). Btw, this doesn't seem to be reverted still. Perhaps you should ask (or notify) gnome-i18n *prior* to reverting.
For the record, see bug #119747 for some objections about adding ngettext support straight away.
Can we revisit this issue now ( http://lists.gnome.org/archives/gnome-i18n/2003-August/msg00127.html)?
*** Bug 119747 has been marked as a duplicate of this bug. ***
I committed this patch to head, and added a check for ngettext to configure.in