After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 118049 - Please use ngettext for handling plurals in gnome-vfs
Please use ngettext for handling plurals in gnome-vfs
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Other
cvs (head)
Other All
: Normal normal
: 2.6
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 119747 (view as bug list)
Depends on:
Blocks: 116236
 
 
Reported: 2003-07-22 10:59 UTC by Danilo Segan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use ngettext to provide plural-forms (500 bytes, patch)
2003-07-22 11:03 UTC, Danilo Segan
none Details | Review

Description Danilo Segan 2003-07-22 10:59:44 UTC
Please see this page which describes the issue in more detail:
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals

This are the incorrect strings:

#: libgnomevfs/gnome-vfs-utils.c:84
msgid "1 byte"

#: libgnomevfs/gnome-vfs-utils.c:86
#, c-format
msgid "%u bytes"

I'll attach a simple patch to fix this.
Comment 1 Danilo Segan 2003-07-22 11:01:33 UTC
Adding a "this bug blocks 116236" according to Christian's suggestion.
Comment 2 Danilo Segan 2003-07-22 11:03:14 UTC
Created attachment 18515 [details] [review]
Use ngettext to provide plural-forms
Comment 3 Christophe Fergeau 2003-07-23 08:28:30 UTC
Will that work on Solaris, AIX, HP/UX or whatever? Does that require
GNU/Gettext? Is GNU/Gettext a requirement for building GNOME ?

Feel free to commit if the answers to these questions are 'yes'.
Comment 4 Christophe Fergeau 2003-08-03 18:58:27 UTC
I committed your patch, but I'd feel more comfortable about it if
someone could certify me that there is a gnome module (intltool or
glib for example) which checks if ngettext is available and doesn't
compile if it's not there...
Comment 5 Danilo Segan 2003-08-03 19:13:59 UTC
CCing Christian because he's the "official" person to ask about these
issues. This was discussed in some other bugs, and reportedly, it was
decided at GUADEC that this was The Right Thing.

Also, see a bug 116236 ("bug 118049 blocks..."), where all of this
should be finally decided before 2.4 release.
Comment 6 Christophe Fergeau 2003-08-13 12:27:21 UTC
The patch has been reverted since it opens a whole can of worms, it's
probably better to wait until 2.6 for that
Comment 7 Danilo Segan 2003-08-13 13:30:42 UTC
I believe that's fine, but you should first announce that on
gnome-i18n because this is going to break a string freeze -- at least
it seems so to me.

(In any case, that patch is included just to indicate that it's a
trivial fix, so whenever it is decided to "go for it", it should be a
simple matter of going through 116236 and closing all the bugs --
alas, string freeze time is not a right time for it).

Btw, this doesn't seem to be reverted still. Perhaps you should ask 
(or notify) gnome-i18n *prior* to reverting.
Comment 8 Christophe Fergeau 2003-08-14 07:48:40 UTC
For the record, see bug #119747 for some objections about adding
ngettext support straight away.
Comment 9 Christian Rose 2003-09-30 08:20:40 UTC
Can we revisit this issue now (
http://lists.gnome.org/archives/gnome-i18n/2003-August/msg00127.html)?
Comment 10 Christophe Fergeau 2003-10-02 07:48:19 UTC
*** Bug 119747 has been marked as a duplicate of this bug. ***
Comment 11 Christophe Fergeau 2003-11-15 16:10:10 UTC
I committed this patch to head, and added a check for ngettext to
configure.in