Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)

Created attachment 21196 [details] [review]
CTRL+Enter on smart URLs + middle button click

Created attachment 21913 [details] [review]
CTRL+Enter in location bar and smart URLs + toolbar middle button click

Dave, what do u think of this ?

I'm ok with this i guess. Well at least the ctrl+enter part of it. I
see no compelling argument against it, and i guess it makes us
consistent with other browsers. not so sure about the whole middle
click thing though...

About ctrl+enter ... how is it faster than ctrl+t. It seem to be
totally unintuitive to me, since it breaks spatial mapping.

I think that ctrl+enter is usefull mostly for smart URLs: e.g: using
the google smart URL you can open a search in a different tab with a
single operation instead of ctrl+t, fill input field, hit enter. IMO
it is good in the loc. bar for consistency.

Marco: since daveb is okay with the Ctrl+enter part, can we check that
part in?

Frankly I'm not thrilled by this. It seem like addition of an
invisible shortcut that would benefit a very very low number of users.
It's completely unintuitive because the entry and the smart bookmarks
are spatially "mapped" to the visible tab and there is no way apart
docs where someone could find it. Last time I talked with Dave he was
not keen of it too. Anyway if I'm alone (Dave and Christian wants it
in), I'm fine with the patch being committed, after being reviewed.

Hm no, I'm only going through bugs with patches attached to see if we
can check them in; I don't really care about the feature either way :)

I guess i should clarify my opinion as being "I don't really care cuz 
i don't really use tabs." I do see where marco is coming from though.

If Ctrl+Enter isn't being used by anything else, I don't see a reason
why we wouldn't want to add this, even if it only benefits a very low
number of users.

I'm never keen of adding hidden keybindings because they have a
maintenance cost. They very easily get broken without anyone noticing.
So I think they should be added when there is a quite good reason to
do it.
Anyway, I'll post on the ml about this.

No one objected to my reasoning on the mailing list -> WONTFIX

*** Bug 142380 has been marked as a duplicate of this bug. ***

Hm. It makes it difficult to open a URL in a new tab -- copy (mouse), control-t
(keyboard), focus location bar (mouse), paste (keyboard or awkward mouse
movement), enter (or go, but I'm so used to doing it with the keyboard after
typing a URL...). It makes more sense to me to smooth it to copy (mouse), focus
(mouse), paste (keyboard), control+enter (keyboard).

> http://mail.gnome.org/archives/epiphany-list/2004-January/msg00003.html

It's doubly annoying when you enter the URL in the current tab, then realize
you'd really like it in a new window. You've already gone through the motions of
entering the URL. Now copy, open new tab, paste, go -- four operations instead
of one control+enter.

I'd love to have someone with some usability testing experience standing over my
shoulder while I gave Epiphany another try this week. I think they'd notice that
that drives me batty, but also see that the bookmark editor is a wonder.

*** Bug 301352 has been marked as a duplicate of this bug. ***

Would it be possible to re-examine part of this bug? at least the middle-click
on smart bookmarks part? I think ctrl-enter is a different issue, which should
be kept separate.

In Galeon, it's very useful to be able to select some text from the page you're
looking at, paste it on a smart bookmark and middle-click the smart bookmark
button; am i alone on this?