After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116804 - Patch to fix some leaks + small cleanups
Patch to fix some leaks + small cleanups
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: CDDBSlave2
2.2.x
Other Linux
: High normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 98980
 
 
Reported: 2003-07-06 08:36 UTC by Kjartan Maraas
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix leaks. (2.78 KB, patch)
2003-07-06 08:36 UTC, Kjartan Maraas 		none Details | Review
new patch updated to match comments (2.83 KB, patch)
2003-07-08 07:38 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2003-07-06 08:36:14 UTC 
Hi.

This patch fixes some leaks in cddb-slave. It also has two minor cleanups,
and forgot why the gconf_client_commit_change_set() stuff is in there, but
I think it was related to a bugreport in gnome-media I tried to fix a while
back. Feel free to ditch that change if it doesn't make sense. :)
Comment 1 Kjartan Maraas 2003-07-06 08:36:35 UTC 
Created attachment 18070 [details] [review]
patch to fix leaks.
Comment 2 Kjartan Maraas 2003-07-06 08:37:08 UTC 
keywords and stuff. Please tell me if this patch looks ok.
Comment 3 Ted Gould 2003-07-06 17:39:56 UTC 
Cool.  Thanks for the patch.  Wouldn't it be better for the g_free's
in the capplet to be inside the 'if (str != NULL)' blocks?  It really
doesn't need to be free'd if it is NULL, and in some cases we might
get a slightly faster execution.
Comment 4 Kjartan Maraas 2003-07-08 07:38:55 UTC 
Created attachment 18124 [details] [review]
new patch updated to match comments
Comment 5 Kjartan Maraas 2003-07-08 07:39:50 UTC 
I updated the patch to match your comments. I still can't remember
what the gconf call was about so you could remove that unless you see
what I was thinking there :)
Comment 6 Kjartan Maraas 2003-07-08 07:46:51 UTC 
The gconf call is an attempt to fix #90788. That's what you get when
you blindly go around trying to fix random stuff without documenting it :)
Comment 7 Kjartan Maraas 2003-07-10 17:08:17 UTC 
I'm going to commit this to the stable branch so I can get GNOME 2.2.2
out.
Comment 8 Ted Gould 2003-07-15 06:34:02 UTC 
Committed to HEAD.  marking as fixed.