Created attachment 16177 [details] [review]
vorbisenc min/max correction

Some things:
- vorbisenc allows to set values < 0 to use managed bitrate, that
should still be allowed.
- oggenc (the program) uses a quality from 0 to 10 with a default of
3. Wouldn't it make more sense to simply divide by 10 when calling
vorbis_encode_init_vbr? (Would require updating the default value from
0.3 to 3)

it looks like negative values are only determining if a quality is
set, you can just as well check if a valid quality is set to do that.

what oggenc does is not really relevant, i think it would be best to
just follow the library specs.

This error seems to come from the fact that parts of the vorbisenc
seemed to be copied from oggenc.

Assigning back to gstreamer-maint, not sure why it was assigned to me :)

Benjamin do you still have objections to this patch?

Patch applied to 0.6 CVS after being reviewed by ds. Tried applying to
head by was told that patch is already applied there. Closing this
bug. Thanks foser