After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786756 - Standarize the option dialog switches
Standarize the option dialog switches
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Universal Access
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-24 13:20 UTC by Felipe Borges
Modified: 2021-06-09 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screen-reader-dialog-screenshot (28.14 KB, image/png)
2017-08-24 13:20 UTC, Felipe Borges
  Details
universal-access: Place the Screen Reader dialog switch in a ListBox (6.14 KB, patch)
2017-08-24 13:20 UTC, Felipe Borges
needs-work Details | Review
universal-access: Style the Screen Reader dialog switch (6.10 KB, patch)
2018-01-23 17:08 UTC, Felipe Borges
committed Details | Review

Description Felipe Borges 2017-08-24 13:20:10 UTC
Created attachment 358336 [details]
screen-reader-dialog-screenshot

The common pattern for the single option dialogs is to embed the label and switches in a GtkListBox (see Privacy -> Location Services).
Comment 1 Felipe Borges 2017-08-24 13:20:35 UTC
Created attachment 358337 [details] [review]
universal-access: Place the Screen Reader dialog switch in a ListBox

This pattern is used all over gnome-control-center in dialogs such
as the Privacy -> Location Services.
Comment 2 Felipe Borges 2017-08-24 13:22:46 UTC
Dialogs TODO:
 * Sound Keys
 * Visual Alerts
 * Repeat Keys (move the Switch from the headerbar into the content area)
 * Cursor Blinking (same as Repeat Keys dialog)
Comment 3 Georges Basile Stavracas Neto 2018-01-23 01:17:18 UTC
Review of attachment 358337 [details] [review]:

One comment.

::: panels/universal-access/uap.ui
@@ +1130,3 @@
         </child>
         <child>
+          <object class="GtkListBox">

We don't actually need a GtkListBox. Can be just a regular container with the 'view' style class' applied.
Comment 4 Felipe Borges 2018-01-23 17:08:21 UTC
Created attachment 367324 [details] [review]
universal-access: Style the Screen Reader dialog switch

This pattern is used all over gnome-control-center in dialogs such
as the Privacy -> Location Services.
Comment 5 Felipe Borges 2018-01-23 17:08:46 UTC
Comment on attachment 358337 [details] [review]
universal-access: Place the Screen Reader dialog switch in a ListBox

reworded the commit message.
Comment 6 Georges Basile Stavracas Neto 2018-01-26 01:37:28 UTC
Review of attachment 367324 [details] [review]:

Looks pretty good to me, thanks!
Comment 7 Georges Basile Stavracas Neto 2018-01-26 01:41:08 UTC
Attachment 367324 [details] pushed as 13d08b4 - universal-access: Style the Screen Reader dialog switch
Comment 8 Georges Basile Stavracas Neto 2018-01-26 02:02:48 UTC
Reopening; there are a few dialog left to be updated.
Comment 9 André Klapper 2021-06-09 16:29:11 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.