After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692936 - Support getting refresh_token from uri fragment
Support getting refresh_token from uri fragment
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-31 12:16 UTC by Jack Leigh
Modified: 2013-02-08 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support getting refresh_token from uri fragment (2.56 KB, patch)
2013-01-31 12:16 UTC, Jack Leigh 		committed Details | Review

Description Jack Leigh 2013-01-31 12:16:40 UTC 
Created attachment 234905 [details] [review]
Support getting refresh_token from uri fragment

This is how it is returned by the Salesforce OAUTH2 system.

Patch attached.
Seems to work in 3.6. Unable to test with 3.7.
Comment 1 Debarshi Ray 2013-02-08 13:30:18 UTC 
Comment on attachment 234905 [details] [review]
Support getting refresh_token from uri fragment

Thanks for the patch. I committed it after moving around the comments a bit. They were beginning to get a bit too complicated.

If you are going to write a Salesforce provider, can you please add some text to README like the other providers? Thanks again.
Comment 2 Debarshi Ray 2013-02-08 13:30:34 UTC 
commit 5a945e0cea0d575c99eac3743212d91162510639
Author: Jack Leigh <jack.leigh@collabora.co.uk>
Date:   Fri Feb 8 14:27:09 2013 +0100

    oauth2: Support getting refresh_token from uri fragment
    
    This is how it is returned by the Salesforce OAuth2 API.
    
    Fixes: https://bugzilla.gnome.org/692936