After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692442 - Replace the hacked up GtkTreeView with a EggListBox
Replace the hacked up GtkTreeView with a EggListBox
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
3.7.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-24 12:09 UTC by Debarshi Ray
Modified: 2013-01-28 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
online-accounts: Replace the hacked up GtkTreeView with a EggListBox (10.48 KB, patch)
2013-01-24 12:20 UTC, Debarshi Ray 		committed Details | Review
Screenshot (16.16 KB, image/png)
2013-01-24 12:23 UTC, Debarshi Ray 		  Details

Description Debarshi Ray 2013-01-24 12:09:07 UTC 
The Notifications, Search and Privacy panel already use a EggListBox which is much easier to use and looks closer to what the designs specify.
Comment 1 Debarshi Ray 2013-01-24 12:20:25 UTC 
Created attachment 234301 [details] [review]
online-accounts: Replace the hacked up GtkTreeView with a EggListBox
Comment 2 Debarshi Ray 2013-01-24 12:23:40 UTC 
Created attachment 234302 [details]
Screenshot

Ran this past the designers in #gnome-design and they are ok with the visuals:
<aday> rishi, yeah looks good
Comment 3 Bastien Nocera 2013-01-27 19:10:00 UTC 
Review of attachment 234301 [details] [review]:

Looks good to me.

The commit message should be:
https://bugzilla.gnome.org/show_bug.cgi?id=692442
not:
Fixes: https://bugzilla.gnome.org/692442
Comment 4 Debarshi Ray 2013-01-28 12:12:23 UTC 
Comment on attachment 234301 [details] [review]
online-accounts: Replace the hacked up GtkTreeView with a EggListBox

Thanks for the review! Committed and pushed to master as suggested.