GNOME Bugzilla – Bug 660882
Drop the notification from EnsureCredentials
Last modified: 2016-10-24 13:07:29 UTC
An application might want to display the error "Can't connect to GoogleTalk account" themselves instead of having the user bombarded with a generic "An online account needs attention" for example http://people.freedesktop.org/~david/goa-expired-credentials.png For example the design of the Documents application appear to call for this feature http://live.gnome.org/Design/Apps/Documents and from IRC it appears empathy wants to use this as well. It's worth noting that the app can already do this - the app can simply just avoid calling EnsureCredentials() but just call e.g. OAuth.GetAccessToken() and then try to use the token. If either OAuth.GetAccessToken() fails or the the web-service returns an "Not Authorized" error when using the token, the app knows the token is bad and the user needs to reauthenticate.
This is something that the designers have been asking for too. In fact, after talking to the designers, I think we don't need a quieter version of EnsureCredentials, but just make what we have now quieter. I am CCing the Allan and Jon, and the maintainers of the affected applications, because it will need changes in the way the applications handle this failure.
I think I have covered everybody -- Empathy, Documents and Evolution.
I think gnome-shell's inbuilt Telepathy client is the worst offender. So we need to figure out how to show the failure in the shell as well. (Adding fmuellner)
(In reply to comment #3) > I think gnome-shell's inbuilt Telepathy client is the worst offender. So we > need to figure out how to show the failure in the shell as well. As it came up at fosdem, I've thought about it a bit. My suggestion would be to use an error icon for the user status, make the presence combo box insensitive, and provide a link to the online accounts panel in the user menu. (Of course we'll need to figure out how we actually detect that case, given that we don't query goa ourselves but via telepathy ...)
Editing the subject to reflect the fact that we don't want a quieter version of EnsureCredentials, but want to drop the notification altogether.
Created attachment 238122 [details] [review] daemon: Do not use notifications when an account needs attention
Now it is over to the applications to deal with it.
(In reply to Debarshi Ray from comment #1) > This is something that the designers have been asking for too. In fact, > after talking to the designers, I think we don't need a quieter version of > EnsureCredentials, but just make what we have now quieter. For the sake of leaving a paper trial, the problem with the desktop notification was that various background daemons kept triggering this error while the user is not consciously using the account. eg., evolution-data-server tries to use the calendar while the user is in the middle of a presentation. This is distracting. Asking the relevant applications to handle it avoids this problem, and there is a clear indication as to what is causing it.
*** Bug 773386 has been marked as a duplicate of this bug. ***