After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659435 - new google authentication page doesn't fit
new google authentication page doesn't fit
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.2.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-19 06:39 UTC by Baptiste Mille-Mathias
Modified: 2012-06-04 20:58 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
screenshot (21.50 KB, image/png)
2011-09-19 16:59 UTC, Baptiste Mille-Mathias
Details

Description Baptiste Mille-Mathias 2011-09-19 06:39:19 UTC
Hi

google releases its new authentication page, and now the page is bigger than the g-o-a html widget and obliges to scroll to access the field of the form.

Perhaps it would be nice to change the dialog size to match the new page.
Comment 1 Baptiste Mille-Mathias 2011-09-19 16:59:14 UTC
Created attachment 196969 [details]
screenshot
Comment 2 David Zeuthen (not reading bugmail) 2011-09-19 17:35:21 UTC
OK, so we make it bigger and then a week later it changes again? It's a game we can't possibly win... From a "we need to release 3.2 soon" point of view, which I'm sympathetic to, not sure how to proceed. There may already be a mobile version of their OAuth 1.0 authentication page but I don't see it in http://code.google.com/apis/accounts/docs/OAuthForInstalledApps.html ... OAuth 2.0 looks more promising, there's an "OAuth 2.0 for devices" section.

(In general, and from a 50,000 feet point of view, I think the only way to do this right is by establishing a relationship between Google and the GNOME foundation (on the executive director level) ... and work out a set of agreements so we are guaranteed that we can e.g. pass e.g. a flag to get a "mobile" or "small" version of the authentication/authorization pages. And we need that relationship for a bunch of other things since we are consuming a lot of their APIs - for example, Google's CalDAV implementation does not support OAuth 1.0 tokens, some services support only OAuth 1.0 while others support only OAuth 2.0 and so on. And then there's the question of API keys and whether we can distribute them and what the situation with upstream/downstream is (we are currently using anonymous keys). We also need to do the same with all other service providers if we want to properly support them... It's kinda intractable.)
Comment 3 amcnabb 2011-11-01 18:51:52 UTC
The window isn't even resizable, so it's impossible for the user to adapt by resizing the window. (Besides, the floating modal dialog is really bizarre. Why not just use a normal window?)
Comment 4 Reinout van Schouwen 2012-01-11 09:16:42 UTC
Observed this problem in Gnome 3.2 (Fedora 16) as well.
Comment 5 Debarshi Ray 2012-03-14 15:04:16 UTC
According to https://developers.google.com/accounts/docs/OAuth_ref#GetAuth adding the btmpl=mobile parameter should provide a mobile version of the page, but currently it is not working.
Comment 6 Debarshi Ray 2012-03-14 23:59:42 UTC
I think there is something broken at Google's end. I tried faking the user agent string with the one on my N9, but it did not work. And manually copying the OAuth 1.0 authorization URL on the phone's browser did not give a different version of the page.

However, if I try to make StackOverflow authenticate using Google, it does provide a mobile version of the page. I do not know what StackOverflow is using -- OAuth 1.0 or 2.0 or something else? Anyone has any insights?
Comment 7 Debarshi Ray 2012-05-15 20:43:30 UTC
It turns out that Google does not recognize the N9's user-agent but does those of Android devices even though they all have "Mobile" in the strings. :-/


commit 1fdeed0dda3fd57b3abccf1f4137820fbde9442c
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Tue May 15 22:03:36 2012 +0200

    Fake the embedded browser's user-agent when needed
    
    The culprit here is Google. It refuses to show the mobile version of
    their page even if btmpl=mobile is passed as mentioned in their
    documentation. Moreover, some mobile browser user-agents do not work.
    eg., Nokia N9. So we fake a HTC Wildfire, instead.
    
    A new virtual method has been added to GoaOAuthProvider and
    GoaOAuth2Provider to allow the providers to specify if they want to
    identify themselves as running on a mobile platform. This is required
    because faking an Android phone can lead to an Android branded version
    of the approval page. eg., with Facebook.
    
    Fixes: https://bugzilla.gnome.org/659435
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.