GNOME Bugzilla – Bug 621368
glib-2.24.1: FAIL: run-assert-msg-test.sh when updating from 2.22.5
Last modified: 2018-01-04 13:31:55 UTC
Created attachment 163468 [details] build.log Reported downstream at: http://bugs.gentoo.org/show_bug.cgi?id=323667 But reproduce even with full upstream sources, this only occurs when updating, probably because that check relies on old installed glib instead or just compiled one. PASS: unicode-caseconv PASS: unicode-encoding PASS: utf8-validate PASS: utf8-pointer PASS: uri-test PASS: regex-test PASS: run-markup-tests.sh PASS: run-collate-tests.sh PASS: run-bookmark-test.sh Test failed: __glib_assert_msg does not have assertion message FAIL: run-assert-msg-test.sh ===================================================================== 1 of 50 tests failed Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=glib ===================================================================== make[4]: *** [check-TESTS] Error 1 make[4]: Leaving directory `/var/tmp/portage/dev-libs/glib-2.24.1/work/glib-2.24.1/tests' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/tmp/portage/dev-libs/glib-2.24.1/work/glib-2.24.1/tests' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/dev-libs/glib-2.24.1/work/glib-2.24.1/tests' make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/dev-libs/glib-2.24.1/work/glib-2.24.1' make: *** [check] Error 2 Thanks for taking care of this
Do you need any more information that could help on fixing this? Any test, file...? Please let me know :-) Thanks a lot
Created attachment 165474 [details] [review] Fix test failure due to missing LD_LIBRARY_PATH export Conditions to reproduce this bug: (1) Install gdb (2) System-wide glib should be lesser than 2.23 (3) Compile glib-2.24 (or greater), and run make check It'll fail at run-assert-msg-test.sh because when gdb is invoked, LD_LIBRARY_PATH hasn't been set yet, and so it will use the system-wide library instead of the compiled one. The attached patch exports LD_LIBRARY_PATH before running ./assert-msg-test or gdb.
Created attachment 165477 [details] [review] Fix test failure due to missing LD_LIBRARY_PATH export *cough* *cough* The previous patch was the wrong one. It was a failed attempt to add $(assert_msg_test_ldadd) to the LD_LIBRARY_PATH export in run-assert-msg-test.sh via Makefile.am I feel that the approach in this patch is easiest since it's the least-change fix for this issue.
Comment on attachment 165477 [details] [review] Fix test failure due to missing LD_LIBRARY_PATH export I think the right way to fix this is to use libtool --mode=execute
Created attachment 208118 [details] [review] Fix test failure due to plain gdb call (In reply to comment #4) > (From update of attachment 165477 [details] [review]) > I think the right way to fix this is to use libtool --mode=execute Looking back after 2 years, I'm wondering why I didn't attach a patch to do this back then. This patch does exactly that now. It should fix the issue.
Review of attachment 208118 [details] [review]: Looks reasonable.
The following fix has been pushed: 840c322 Run gdb under libtool so that local libraries are used
Created attachment 208969 [details] [review] Run gdb under libtool so that local libraries are used If this isn't done, the system-wide glib is used for this test, and that can cause test failures. https://bugzilla.gnome.org/621368
*** Bug 615619 has been marked as a duplicate of this bug. ***