After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731930 - modplug: don't hardcode c++ standard lib in Makefile.am
modplug: don't hardcode c++ standard lib in Makefile.am
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other FreeBSD
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-19 18:18 UTC by Koop Mast (kwm)
Modified: 2014-06-28 08:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't hardcode c++ standard lib. (913 bytes, patch)
2014-06-19 18:19 UTC, Koop Mast (kwm)
committed Details | Review

Description Koop Mast (kwm) 2014-06-19 18:18:50 UTC
On FreeBSD the default c++ standard library is libc++ (from llvm).
Don't hardcode -lstdc++ (GNU gcc library) in the Makefile and let the compiler figure it out.
Comment 1 Koop Mast (kwm) 2014-06-19 18:19:15 UTC
Created attachment 278791 [details] [review]
Don't hardcode c++ standard lib.
Comment 2 Tim-Philipp Müller 2014-06-22 20:53:55 UTC
Pushed, thanks:

commit 386e5774a798305298172fe718e9b3f14af75f9c
Author: Koop Mast <kwm@rainbow-runner.nl>
Date:   Thu Jun 19 20:15:05 2014 +0200

    modplug: don't hardcode c++ standard library
    
    Fixes build with llvm on FreeBSD.
    
    https://bugzilla.gnome.org//show_bug.cgi?id=731930