After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731783 - h265parse: incorrect value used to check size of hvcC data
h265parse: incorrect value used to check size of hvcC data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-17 13:45 UTC by Chris Bass
Modified: 2014-06-28 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix value used in hvcC size check (1.05 KB, patch)
2014-06-17 13:45 UTC, Chris Bass
committed Details | Review

Description Chris Bass 2014-06-17 13:45:46 UTC
Created attachment 278601 [details] [review]
Fix value used in hvcC size check

In ISO/IEC 14496-15, the minimum size of a HEVCDecoderConfigurationRecord (i.e., the contents of a hvcC box) is 23 bytes. However, the code in h265parse checks that the size of this data is not less than 28 bytes, and it refuses to accept caps if the check fails. The result is that standards-conformant streams that don't carry any parameter sets in their hvcC boxes won't play.

The attached patch fixes this check and also the error message that is output if the check fails.
Comment 1 Tim-Philipp Müller 2014-06-22 20:58:46 UTC
Thanks for the patch, pushed:

commit d9d4a91c62b8e2f021e5e8039bb1368f825b8d62
Author: Chris Bass <floobleflam@gmail.com>
Date:   Tue Jun 17 14:23:43 2014 +0100

    h265parse: fix hvcC size check
    
    In ISO/IEC 14496-15, the minimum size of a HEVCDecoderConfigurationRecord
    (i.e., the contents of a hvcC box) is 23 bytes. However, the code in h265parse
    checks that the size of this data is not less than 28 bytes, and it refuses to
    accept caps if the check fails. The result is that standards-conformant streams
    that don't carry any parameter sets in their hvcC boxes won't play.
    
    https://bugzilla.gnome.org//show_bug.cgi?id=731783