GNOME Bugzilla – Bug 731692
Fix include GL and GLES header check with clang.
Last modified: 2014-06-28 08:30:15 UTC
Clang will only give a warning for the redefinition of typedef GLenum in C11 mode. Since master is build with -Werror this will result in a build failure later in the gl plugin. Add -Werror to the test, so the test result is as expected. This will allow the gl plugins to build. configure:33737: checking whether it is possible to include both GL and GLES2 headers configure:33754: cc -c -O2 -pipe -O2 -Wno-format -fno-strict-aliasing -I/usr/local/include conftest.c >&5 In file included from conftest.c:77: /usr/local/include/GL/gl.h:149:22: warning: redefinition of typedef 'GLenum' is a C11 feature [-Wtypedef-redefinition] typedef unsigned int GLenum; ^ /usr/local/include/GLES2/gl2.h:23:26: note: previous definition is here typedef unsigned int GLenum; ^
Created attachment 278496 [details] [review] Add -Werror to GL and GLES2 check
Review of attachment 278496 [details] [review]: This needs to be wrapped in AS_COMPILER_FLAG to check if the compiler supports -Werror. There are also some other exotic -Werror variants in common/m4/gst-error.m4
commit 5f00de460133945113dbba476274a1077ef72f13 Author: Tim-Philipp Müller <tim@centricular.com> Date: Sun Jun 22 22:04:31 2014 +0100 configure: use $ERROR_CFLAGS instead of hard-coding -Werror https://bugzilla.gnome.org//show_bug.cgi?id=731692 commit a84406c09b937b135f772ee9555e61c3f0d52a9c Author: Koop Mast <kwm@rainbow-runner.nl> Date: Sun Jun 15 21:15:51 2014 +0200 configure: use -Werror to make the include GL and GLES2 header check guaranteed fatal Clang will only give a warning for the redefinition of typedef GLenum. Since master is build with -Werror this will result in a build failure later in the gl plugin. Add -Werror to the test, so the test result is as expected. This will allow the gl plugins to build. https://bugzilla.gnome.org//show_bug.cgi?id=731692