After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98745 - window borders hard to see with inverse GTK+ themes
window borders hard to see with inverse GTK+ themes
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2002-11-16 23:57 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tiny patch to draw borders in fg[NORMAL] for inverse gtk+ themes. (1.63 KB, patch)
2002-11-17 00:05 UTC, bill.haneman
none Details | Review

Description bill.haneman 2002-11-16 23:57:37 UTC

Comment 1 bill.haneman 2002-11-17 00:04:41 UTC
Many of the Metacity themes don't work so well with the "inverse"
themes, for instance HighContrastInverse and
HighContrastLargePrintInverse.  In these two themes the window borders
are not delineated from the dark backgrounds of other windows'
contents, so the windows are hard to distinguish from one another (one
of the primary functions of window borders).

It's too bad, since the themes affected, such as Atlanta, are
otherwise possibly the best for low-vision users. 

There's a simple fix though, that goes a long way to making this
better;  use gtk:fg[NORMAL] instead of 0x0000000 where borders and
black bevels are currently drawn.

Attached is a patch for Atlanta that fixes the problem without
affecting Atlanta's look for the other available themes, including
'Default'.

Havoc, can I commit this 2-line patch?  It really does help a lot.
Comment 2 bill.haneman 2002-11-17 00:05:46 UTC
Created attachment 12350 [details] [review]
tiny patch to draw borders in fg[NORMAL] for inverse gtk+ themes.
Comment 3 Havoc Pennington 2002-11-17 00:10:35 UTC
Looks good, go ahead and commit.
Comment 4 bill.haneman 2002-11-17 12:01:36 UTC
Fixed in CVS, thanks Havoc.