After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98589 - Menus in terminal have icons even when the option is disabled
Menus in terminal have icons even when the option is disabled
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: High trivial
: ---
Assigned To: Havoc Pennington
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-11-15 12:29 UTC by Muktha
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (6.18 KB, patch)
2002-11-26 04:52 UTC, Pasupathi 		none Details | Review
modified patch (7.71 KB, patch)
2003-01-06 06:11 UTC, Pasupathi 		none Details | Review
patch with review comments incorporated (7.81 KB, patch)
2003-02-03 15:08 UTC, Pasupathi 		none Details | Review

Description Muktha 2002-11-15 12:29:47 UTC 
I'm running sources from 14th Nov (CVS head)

1. Invoke terminal.
2. Invoke the 'Menus and Toolbars' capplet (Desktop Preferences-> Menus &
   Toolbars)
3. Disable the option 'Show icons in menus' by unchecking the checkbox. 
4. The menus in the terminal should not have icons but they will still
   have.
Comment 1 Heath Harrelson 2002-11-18 22:51:23 UTC 
I'm marking this trivial, but it really should be fixed.  Maybe I'll
give it a try myself.
Comment 2 Pasupathi 2002-11-26 04:52:54 UTC 
Created attachment 12557 [details] [review]
Proposed patch
Comment 3 Heath Harrelson 2002-11-26 05:16:42 UTC 
Patch = high.  Thanks!
Comment 4 Pasupathi 2003-01-06 06:10:34 UTC 
My previous patch doesn't handle (i.e. remove the) notify id which is 
generated during creation of stock menu items. I modified the patch a 
bit, such that notify id's are properly removed in the finalize 
function. Pls. look at the new patch.
Comment 5 Pasupathi 2003-01-06 06:11:16 UTC 
Created attachment 13373 [details] [review]
modified patch
Comment 6 Havoc Pennington 2003-01-06 18:13:40 UTC 
Needs to be robust against "gconftool --break-key" on the 
menus have icons setting.

i.e. in the notify, check entry->value != NULL and entry->value->type
== GCONF_VALUE_BOOL
Comment 7 Pasupathi 2003-02-03 15:08:28 UTC 
Created attachment 14057 [details] [review]
patch with review comments incorporated
Comment 8 Kjartan Maraas 2003-04-22 15:02:42 UTC 
Havoc, any chance of getting this in?
Comment 9 Havoc Pennington 2003-04-22 15:26:02 UTC 
Fine to commit this to HEAD
Comment 10 Kjartan Maraas 2003-04-24 14:44:23 UTC 
Commited.