After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98306 - Eject does not work for non-local user on Nautilus media icons
Eject does not work for non-local user on Nautilus media icons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.0.x
Other Solaris
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-11-12 10:51 UTC by Narayana Pattipati
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (751 bytes, patch)
2002-11-13 05:44 UTC, Narayana Pattipati
none Details | Review

Description Narayana Pattipati 2002-11-12 10:51:14 UTC
This is really a strange bug. When a media is inserted, a number of options
are available for the user to either Eject, format, Media Properties and
protection oprions. But those options are not working. Clicking on Eject
does not do anything.

It works fine with root and local user, but not NIS or may be user with NIS
mounted home directory.
Comment 1 Narayana Pattipati 2002-11-13 05:42:29 UTC
The callback(volume_ops_callback) for the options Eject, media
properties, format etc. has a check which is causing the problem.

nautilus/src/file-manager/fm-desktop-icon-view.c:volume_ops_callback()

   896          if (!nautilus_file_is_local (file)) {
   897                  nautilus_file_list_free (selection);
   898                  return;
   899          }

This check fails for non-local files. But it is not required for
volumes since, volumes we care about are on the desktop.

Removing the above check will solve the problem. Also it will not
cause any side effects also as the callback is only for volumes.

I will attach a patch with these changes.
Comment 2 Narayana Pattipati 2002-11-13 05:44:40 UTC
Created attachment 12268 [details] [review]
Proposed patch.
Comment 3 Alexander Larsson 2003-04-23 10:46:23 UTC
Another bug caused by the stupid is_local() change.
Just removing the check isn't good enought, as it could be a
theoretical "security" issue. I fixed this in CVS.