GNOME Bugzilla – Bug 98240
"border-size" not working
Last modified: 2006-11-09 19:53:41 UTC
"border-size" and "border-color" properties of the magnifier are not warking at all. If I launch magnifier -v --border-size=10 --border-color=1024 there is no effect.
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME bug list :)
Oops... apologies for changing the priority, resetting to Normal and adding AP4 whiteboard comment instead.
*** Bug 137249 has been marked as a duplicate of this bug. ***
border-color is now working, if border-size is > 0. However border-size itself is still not working.
lowering priority for now.
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
Created attachment 73233 [details] [review] Make border size work and alter how border color work
I forget to comment in the previous post the way the --border-color paramenter works. Let's assume these bits: 23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 2 1 0 0 |0 |0 |0 |0 |0 |0 |0 |0 |0 |0 |0 |0 |0 |0|0|0|0|0|0|0|0|0|0| If you want a blue border you must pass the value 255, the 8 lowest bits setted. A green border, you must pass the value 65280, all bits from 8 to 15 setted and a red border you must pass the value 16711680, all bits from 16 to 23 setted. If you want white you must pass the value 16777215, the sum of red, green and blue.
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.
Reopening bug, since this patch introduced some regressions. Try call "#: ./control-cleint c" or "#: ./mag-test" They doesn't work properly.
Created attachment 76160 [details] [review] this correct the issues introdudeced by the old patch and rework a little the gnome-mag code This new patch makes a new gtk_drawing_area to represent the border and remove the exposed_viewport, since the last is calculated from the border_size and now the border size is in a different object, so the zoom region viewport is the only viewport needed, because the exposed_viewport was used to clip the final image, that can't be drawed over the border.