GNOME Bugzilla – Bug 98202
No capplets should set close as the default button
Last modified: 2005-01-01 23:18:33 UTC
I was usgin gnome 2 days without mouse, and I wasn't be able to add/change a keybindig, because if I press enter over the tree item the dialog closes. I know that gnome is very mouse oriented, but I don't know if this is a accesibility problem
Everything in GNOME should work from the keyboard. Having something like keyboard bindings not working from the keyboard is quite a major accessibility problem. Thanks, Fernando.
It's not quite as serious as it first appears, as it works (for me, anyway) if you press spacebar rather than Enter-- but only if focus is in the second column. However, the HIG recommends that instant apply dialogs like this shouldn't set Close as the default button, so that's the real bug here. Also, spacebar should probably work whether focus is in the first or second column.
Retitling: "No capplets should set close as the default button"
Created attachment 12570 [details] [review] Simple patch fixing most capplets
Created attachment 12571 [details] [review] REAL. patch.. (grr. screwy mozilla file picker!)
Is there any reason why this hasn't been applied?
Humm, we're now in UI freeze for gnome2.2. I think we need to ask the release-team.
Urm... I wouldn't have thought this needs release team approval, since it's the sort of HIG violation that a UI-review _should_ pick up. And UI-reviews are exempt from the freeze. And it's not a destabilising patch.
Ops. I've just mailed release-team (after asking Jeff about it).
Well that was just my opinion. It wasn't authoritive :-)
yes... here is the Murray answer: Sat, Dec 07, 2002 at 04:46:02PM +0100, Murray Cumming escribió: >I thought that all ui-review bugs discovered before the UI freeze could >be fixed. Aren't all "usability" bugs also "ui-review" bugs? and his is in the relase team :) So please, apply!
Not apply yet, please. Release team is discussing about this.
Was this ever fixed/applied?
Upping pri, adding keyword.
If not, NOW is the time to do it.
Fixed for keyboard shortcuts, not fixed for other capplets.
Font, mouse, keyboard, and ui still needs to be fixed. Why in the hell we only remember about this bug during freezes?
Fernando: Because the BLOCKED_BY_FREEZE keyword didn't exist. :)
ping : can this patch be applied ?
This patch (attachment 10744 [details] [review]) does not apply to CVS anymore, due to the name change of the background properties capplet. Andrew, can you come up with a new patch ? Thanks !
Comment on attachment 12571 [details] [review] REAL. patch.. (grr. screwy mozilla file picker!) Since the patch no longer applies, I'm changing the status from accepted to needs-work. Kick me if you'd rather I handled this in a different way.
Created attachment 33397 [details] [review] Simple patch fixing some cappletts Similar to Andrew Johnson's earlier patch
patch commited, thanks