After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 97047 - Radar map needs scrollbars
Radar map needs scrollbars
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
2.0.x
Other other
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-10-28 17:47 UTC by Havoc Pennington
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
patch tat has a small problem (2.09 KB, patch)
2004-06-11 07:24 UTC, santhosh
none Details | Review
patch which adds scrollbar to radar map (2.23 KB, patch)
2004-06-11 18:14 UTC, santhosh
none Details | Review
final patch (2.33 KB, patch)
2004-06-12 17:36 UTC, santhosh
none Details | Review

Description Havoc Pennington 2002-10-28 17:47:24 UTC
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=76873
Comment 1 Gareth Owen 2004-06-09 14:38:38 UTC
I can't reproduce this on CVS Head.  The forecast window now resizes to fully
display the radar map.
Comment 2 Dennis Smit 2004-06-09 15:23:43 UTC
Problem is that some radar maps are so big that they don't fit on the screen
and the window refuses to resize to a decent size because of the size
requisition that the image requests. Thus the solution is to put it
in scrollbars (the image).
Comment 3 Dennis Smit 2004-06-09 18:56:01 UTC
Being worked on by Santhosh
Comment 4 santhosh 2004-06-11 07:24:23 UTC
Created attachment 28584 [details] [review]
patch tat has a small problem

dennis : plz try this patch and u  itself can see a problem in vertical
scrolling.
	 plz tel me wat should i do for tat and i ll make that change.
Comment 5 Dennis Smit 2004-06-11 11:48:10 UTC
Comments:

1. Strictly keep yourself to the indenting of the file.
2. Missing ChangeLog
3. I don't know what is wrong on the top of my head, and I'll
   be out of town for the weekend.
4. Imagescroll_window use imagescroll_window seen all the other
   variables are named like that.
5.
+  GtkWidget *Imagescroll_window;
+  GtkAdjustment *vadjus;
+  vadjus = gtk_adjustment_new(0,0,256,8,16,32);

You're not using this.. so don't have it in the source :)

6. I think looking at the gtk_box_pack_start flags might help, not sure
   tho.
Comment 6 santhosh 2004-06-11 18:14:11 UTC
Created attachment 28609 [details] [review]
patch which adds scrollbar to radar map

thanks for dennis :)
Comment 7 Dennis Smit 2004-06-12 13:50:47 UTC
Ok this starts to look really good, I won't be at home for a few days
so I can't check it in right away.

A few small comments tho that would make it better (yeah we can be picky):
1. In the ChangeLog entry include filename/function like done in
other entries in the ChangeLog.

2. When you look at the patch you can see that a few lines aren't indented
in style with the rest of the source.

It would be great if you could fix these two issues and i'll look at it
when i'm back home!

Great job!
Comment 8 santhosh 2004-06-12 17:36:16 UTC
Created attachment 28641 [details] [review]
final patch
Comment 9 santhosh 2004-06-12 17:44:24 UTC
can u assign me next bug plz.
Comment 10 Dennis Smit 2004-06-12 20:38:03 UTC
Thanks a lot for the patch, i'll look at it within a few days when i'm
back home!

You could take a bite at: #143737 This is very important to get RIGHT
so when you've got a patch try to check up with the reporter if your
patch is the right solution!



Comment 11 Dennis Smit 2004-06-16 19:41:56 UTC
Thanks a lot Santhosh!!!

___
2004-06-16  Dennis Smit  <ds@nerds-incorporated.org>

        * gweather-dialog.c (gweather_dialog_create):
        Added scrollbars to the radar map.

        Patch by: S.SanthoshKumar  <santhu842k2@yahoo.co.in>

        Fixes bug #97047.