GNOME Bugzilla – Bug 97047
Radar map needs scrollbars
Last modified: 2004-12-22 21:47:04 UTC
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=76873
I can't reproduce this on CVS Head. The forecast window now resizes to fully display the radar map.
Problem is that some radar maps are so big that they don't fit on the screen and the window refuses to resize to a decent size because of the size requisition that the image requests. Thus the solution is to put it in scrollbars (the image).
Being worked on by Santhosh
Created attachment 28584 [details] [review] patch tat has a small problem dennis : plz try this patch and u itself can see a problem in vertical scrolling. plz tel me wat should i do for tat and i ll make that change.
Comments: 1. Strictly keep yourself to the indenting of the file. 2. Missing ChangeLog 3. I don't know what is wrong on the top of my head, and I'll be out of town for the weekend. 4. Imagescroll_window use imagescroll_window seen all the other variables are named like that. 5. + GtkWidget *Imagescroll_window; + GtkAdjustment *vadjus; + vadjus = gtk_adjustment_new(0,0,256,8,16,32); You're not using this.. so don't have it in the source :) 6. I think looking at the gtk_box_pack_start flags might help, not sure tho.
Created attachment 28609 [details] [review] patch which adds scrollbar to radar map thanks for dennis :)
Ok this starts to look really good, I won't be at home for a few days so I can't check it in right away. A few small comments tho that would make it better (yeah we can be picky): 1. In the ChangeLog entry include filename/function like done in other entries in the ChangeLog. 2. When you look at the patch you can see that a few lines aren't indented in style with the rest of the source. It would be great if you could fix these two issues and i'll look at it when i'm back home! Great job!
Created attachment 28641 [details] [review] final patch
can u assign me next bug plz.
Thanks a lot for the patch, i'll look at it within a few days when i'm back home! You could take a bite at: #143737 This is very important to get RIGHT so when you've got a patch try to check up with the reporter if your patch is the right solution!
Thanks a lot Santhosh!!! ___ 2004-06-16 Dennis Smit <ds@nerds-incorporated.org> * gweather-dialog.c (gweather_dialog_create): Added scrollbars to the radar map. Patch by: S.SanthoshKumar <santhu842k2@yahoo.co.in> Fixes bug #97047.