After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 95501 - gnome-vfs should check for modules in /usr/local
gnome-vfs should check for modules in /usr/local
Status: RESOLVED WONTFIX
Product: gnome-vfs
Classification: Deprecated
Component: Module: (other)
cvs (head)
Other All
: Normal enhancement
: ---
Assigned To: Christian Neumair
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2002-10-11 13:33 UTC by Simon Howard
Modified: 2008-09-06 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (against HEAD). (1.42 KB, patch)
2005-05-08 20:26 UTC, Christian Neumair
none Details | Review
Proposed patch (2.36 KB, patch)
2006-07-14 18:28 UTC, Christian Neumair
none Details | Review

Description Simon Howard 2002-10-11 13:33:40 UTC
Currently gnome-vfs only looks for modules installed in its install prefix
and in directories specified in the GNOME_VFS_MODULE_PATH. It ought to look
in /usr/local/lib/gnome-vfs-xxx/modules as well so that third party modules
can be compiled from source and installed in /usr/local in compliance with
the Filesystem Hierarchy Standard. Currently such modules must either be
installed into the gnome install prefix (which may be /usr if installed
from packages: if the extra modules are being compiled from source this is
the wrong place) or hack the gnome startup scripts to edit
GNOME_VFS_MODULE_PATH.
Comment 1 Christian Neumair 2005-05-08 15:45:46 UTC
Thanks for your bug report!
I wonder whether there is any standard on whether $prefix/local (or
specifically, /usr/local?) should also be scanned. I couldn't find any /local
specs in the LSB.
Is using /usr/local as a target path for user installation really that common?

Sidenote: Relevant code is in libgnomevfs/gnome-vfs-method.c:init_path_list.
Comment 2 Simon Howard 2005-05-08 19:01:07 UTC
I filed this bug report because I am the author of a gnome-vfs module which
allows access to Psion palmtops.  My problem is this:

* gnome-vfs is installed as part of my system (debian package)
* I distribute my module as source code to be compiled and installed.
* The FHS says that software compiled and installed by the user should be
installed into /usr/local or /opt.  Therefore to comply with this, my module
should be installed there.
* gnome-vfs only searches in /usr/lib/gnome-vfs-2.0, so I am forced to install
my module into /usr, breaking the FHS.  Alternatively, I can try to hack
GNOME_VFS_MODULE_PATH, but then I'd need to get all users to set this up every
time they log in.
Comment 3 Sebastien Bacher 2005-05-08 20:00:28 UTC
what about packaging it so it's installed to /usr ? :)
Comment 4 Christian Neumair 2005-05-08 20:26:32 UTC
Created attachment 46188 [details] [review]
Proposed patch (against HEAD).

Even if this use-case may be a bit rare, many specs suggest to also respect
these local directory constructions, including the XDG base directory spec [1].
So after all, it could be a good idea to add this.
On the patch: We don't have to expose this variable to configure, right?  I
don't know any reason for overriding the GNOME_VFS_LOCAL_LIBDIR variable.

[1] http://freedesktop.org/Standards/basedir-spec
Comment 5 Stanislav Brabec 2006-03-10 21:47:16 UTC
Additionally, after setting this variable to a path, each program complains (but works):

GNOME_VFS_MODULE_CONFIG_PATH=/usr/local/etc/gnome-vfs-2.0/modules:/etc/opt/gnome/gnome-vfs-2.0/modules GNOME_VFS_MODULE_PATH="/usr/local/lib/gnome-vfs-2.0/modules:/opt/gnome/lib/gnome-vfs-2.0/modules" gnomevfs-ls ftp://ftp.gnome.org/

(process:17447): libgnomevfs-WARNING **: Cannot load module `/usr/local/lib/gnome-vfs-2.0/modules/libftp.so' (/usr/local/lib/gnome-vfs-2.0/modules/libftp.so: cannot open shared object file: No such file or directory)
.               (Directory, x-directory/normal) size 8192       mode 0755
..              (Directory, x-directory/normal) size 8192       mode 0755
.temp-nikke             (Directory, x-directory/normal) size 8192       mode 0700
HEADER.html             (Regular, text/html)    size 1006       mode 0644
Public   [link: /pub ]  (Directory, x-directory/normal) size 8192       mode 0755
...
Comment 6 Christian Neumair 2006-07-14 18:28:21 UTC
Created attachment 68940 [details] [review]
Proposed patch

Christian Kellner and I agreed that scanning /usr/local by default isn't neccessary because it is a rather uncommon setup.

The new attached patch will prevent GnomeVFS from bailing when a module could not be found in any of the module directories if it later could be found in another directory. The codepaths aren't too pretty, but without major reorganization we can't tell load_module whether it's acting on a module specified by an absolute or a relative path.
Comment 7 André Klapper 2008-09-06 18:54:13 UTC
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome.

If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs.

@Bugzilla mail recipients: query for
      gnome-vfs-mass-close
to get rid of this notification noise all together.


General further information: http://en.wikipedia.org/wiki/GVFS 
Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html