Bug 95008 – Don't assume ${prefix}/share != ${datadir}

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 95008 - Don't assume ${prefix}/share != ${datadir}


Summary:	Don't assume ${prefix}/share != ${datadir}

Attachments
Proposed patch. (637 bytes, patch) 2004-07-24 12:04 UTC, Christian Neumair	none	Details \| Review

Description The Written Word 2002-10-06 16:53:47 UTC

Should GNOME_ICONDIR be ${prefix}/share or ${datadir} in
libbackground/Makefile.am? The two are not always equivalent. I recommend
${datadir}.

Comment 1 Aschwin van der Woude 2002-12-14 15:51:28 UTC

Version 2.1.4 has the same.

Comment 2 Christian Neumair 2004-07-24 12:04:35 UTC

Thanks for your bug report.

Comment 3 Christian Neumair 2004-07-24 12:04:59 UTC

Created attachment 29846 [details] [review]
Proposed patch.

Comment 4 Luis Villa 2005-01-02 16:33:31 UTC

Christian, have you emailed nautilus list about this? Let's nag Alex and get
this committed...

Comment 5 Martin Wehner 2005-01-29 21:42:25 UTC

Committed. Thanks Manny.

Comment 6 Martin Wehner 2005-01-29 22:14:44 UTC

I suck. I had to revert my commit because libbackground is just a link into
gnome-control-center. This bug/patch actually belongs there. Sorry.

Comment 7 Kjartan Maraas 2005-02-10 00:24:19 UTC

Isn't the patch correct regardless of whether it belongs in gnomecc or not? Can
we get this in?

Comment 8 Rodney Dawes 2005-02-10 05:11:32 UTC

I've just committed a patch to remove the line entirely. There's no need to
define the GNOME_ICONDIR variable at all, as the code doesn't use it.