GNOME Bugzilla – Bug 94856
Ctrl+F10 should not be used by bonobo toolbar
Last modified: 2004-12-22 21:47:04 UTC
Ctrl+F10 should not be used by bonobo toolbar. 1) Coz in Nautilus if you right click on the main pane it should bring up the main pane popup : the one that starts with "New Window". The same one that pops up when u right click on the desktop. 2) Thats not how it is in gtk+ ( in terms of consistancy )
Last time I looked the a11y guidelines on developer.gnome.org said we should use C-F10, the fact it doesn't work with gtk+ is gtk+ problem; I tried to do my bit ;-) Unfortunately the solution is horribly inelegant; it needs fixing in 2.2 to use a shared toolbar with Gtk+ preferably with sensible item navigation.
Michael is quite right, of course... what he implemented is exactly what we originally proposed in the keynav draft, and also how gtk originally implemented it (albeit only for cycling focus between multiple menubars, such as you get on the menu panel-- toolbars were, and still are, absent from the keynav sequence until a later release). Unfortunately as keynav implementation progressed, we found that we had to use Ctrl-F10 and Ctrl-Tab for other things, which gave us a consistency problem, and that the proposed scheme for cycling between menubars/toolbars was unnecessarily complicated anyway. So, we proposed a new scheme-- just use F10 to cycle between all available menubars and toolbars-- which Owen agreed with and implemented in gtk. Unfortunately I completely forgot that Michael had already implemented bonobo toolbar keynav, so we didn't include him in the discussion :( I can only apologise for that. (This also reminds me that the keynav spec on d.g.o. is rather out of date. It's now almost-the-top-of-my-list to update, though...)
See gtk+ bug #54047. GtkToolbar is not on the F10 focus chain, only menubars are. I'm going to make #54047 block this bug. If the correct solution is for GtkToolbars to be on the F10 focus chain then bonoboui would need some method to add BonoboDockBands to that focus chain.
Michael: how would you feel about disabling Ctrl-F10 until a consitent solution is found ?
Very happy - I'd want the hacks removed to do the focus navigation at the same time - there was some significant ugliness in there that needs to go fast. Just a lack of time to get to this really.
Michael: I'm tempted to just remove bonobo_dock_focus_roll and leave the rest of the keynav implementation - which would resolve this collision. e.g. leave it so you can still navigate and move the toolbars around by holding down control and using the arrow keys. Or are you in favour of removing all toolbar keynav impl. until a standard method is decided ?
I'm in favour of removing as much of the cruft I added there as possible - particularly the evilness to change the focus tree when Control is held down [argh]. It screws with some apps on startup for reasons I don't understand, and it's all bad news & should go ideally.
Updating status_whiteboard field to reflect A11Y team's assessment of accessibility impact.
So this feature is removed in CVS HEAD - I suppose that makes things consistant; but it seems there is no way to get to eg. the nautilus location toolbar item in nautilus now; revert patch attached.
Created attachment 15700 [details] [review] patch of reversion of this feature