After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 93360 - border for the crop tool
border for the crop tool
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal enhancement
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
: 122412 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-09-16 02:57 UTC by airfullbete
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that implements darkening of the area outside the crop rectangle (13.53 KB, patch)
2004-09-30 18:37 UTC, Sven Neumann
none Details | Review

Description airfullbete 2002-09-16 02:57:38 UTC
Another suggestion for improving the crop tool (aside the fixed aspect 
ratio in particular). 
 
When I play with the crop tool, I sometimes have difficulties to imagine 
the end result. So I crop and undo, crop and undo, and so on until I get 
what I want. It would be very nice to have the exterior of the crop 
rectangle filled up with a solid color (black for example - or it could 
be customable). That would give a much better idea of the end result. Of 
course that behavior should be optional, otherwise it would become 
difficult to find the best position of the rectangle. It could be toggled 
by a radio button in the crop tool dialog or better, by pressing (and 
holding?) a key. 
 
What do you think of this? 
 
AirBete.
Comment 1 Sven Neumann 2002-09-16 09:48:34 UTC
This is in the TODO list for some years now. Someone should go ahead
and implement this feature.
Comment 2 Sven Neumann 2002-09-16 09:54:24 UTC
For the reference, here's the relevant part from the TODO:

 Crop tool could have an optional shader for the outside area
 so when you crop, the area outside would show in a darker color /
 user definable color / black / white etc.. (maybe a selector for
 the outside area:
                       ____________ 
       Outside fill: [|_none_______| = ]
                      |.black......|
                      |.white......|
                      |.user def...|
                      |.shade 50%..|
                      `------------'
 That would be very handy for cropping scanned photos etc - 
 one would see the result much easier apart from the rest.

Comment 3 Alan Horkan 2003-07-23 18:41:58 UTC
Changes at the request of Dave Neary on the developer mailing list.  
I am changing many of the bugzilla reports that have not specified a target
milestone to Future milestone.  Hope that is acceptable.  
Comment 4 Tino Schwarze 2003-07-24 09:54:42 UTC
Setting milestone to 1.3.x because it would improve usability a lot.
Removed "black" from Summary.
Comment 5 Dave Neary 2003-07-26 20:33:17 UTC
Chopping from 1.3.x, because no-one's working on it, and it doesn't
look that straightforward.

Dave.
Comment 6 Sven Neumann 2003-09-16 08:35:39 UTC
*** Bug 122412 has been marked as a duplicate of this bug. ***
Comment 7 airfullbete 2004-06-07 17:44:10 UTC
Any progress on this "bug"? Thanks.
Comment 8 Sven Neumann 2004-06-07 18:14:49 UTC
If there was any, we would have added a comment about it. Are you working on it?
Comment 9 Sven Neumann 2004-09-30 18:37:12 UTC
Created attachment 32124 [details] [review]
patch that implements darkening of the area outside the crop rectangle
Comment 10 Sven Neumann 2004-10-01 09:50:09 UTC
2004-10-01  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c: no need to include
	gimpdisplayshell-render.h here.

	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell-render.[ch]

	* app/display/gimpdisplayshell.[ch]: added an API to highlight a
	rectangle (specified in image coordinates). Actually it doesn't
	highlight but dims the area outside the rectangle.

	* app/tools/gimpcroptool.c: use the new functionality to show the
	area to be cropped. Fixes bug #93360.