After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 92852 - Icons in the Applications menu and Applet icons in the "Add to Panel" menu not resizing
Icons in the Applications menu and Applet icons in the "Add to Panel" menu no...
Status: RESOLVED NOTABUG
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other All
: High major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
AP1
Depends on: 91686
Blocks:
 
 
Reported: 2002-09-09 13:51 UTC by Calum Benson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
Proposed patch (826 bytes, patch)
2002-11-11 17:12 UTC, padraig.obriain
none Details | Review
Screenshot showing menu icons not scaling properly (73.40 KB, image/png)
2003-04-04 11:31 UTC, Calum Benson
  Details

Description Calum Benson 2002-09-09 13:51:26 UTC
Running with the latest icon-sizing patch in bug #70648, starting from
default theme:

- Choose a large-icon theme, e.g. HighContrastLargePrint: all panel menu
icons get bigger
- Choose the default theme again

All panel menu icons get smaller *except* the third level ones on the panel
menu, e.g. Add to Panel->Internet->Inbox Monitor.  The third level icons on
the Apps & Actions menus resize fine.

Sometimes you have to alternate between themes a couple of times before
this happens-- I think you actually have to open the affected menu after
each theme change to make the icon render before things get out of sync.

Not sure if this is a panel bug (third level icons not respecting
panel-menu size?) or an icon-sizing patch bug, but filing it here first for
a bit of variety :)
Comment 1 Brian Cameron 2002-09-09 14:10:21 UTC
One thing worth noting is that all the icons that have problems
are all applets, which is perhaps a bit more telling than simply
saying that "third-level" panel menu icons are not resizing.

I notice that if you go to the menu, pick "Add to Panel" and
then "Launcher from Menu" that these icons are also "third-level"
but they are all sizing properly.  A difference is that these 
working "third-level" icons are not for applets.

Comment 2 Mark McLoughlin 2002-09-11 01:53:17 UTC
Hmm, I'd imagine this happens with launcher icons too no ?

If you look at load_icons_handler, if its not an icon with a stock id
we scale the pixbuf there and then an set the pixbuf on the GtkImage.
We probably need to be notified of the icon size change and re-scale
the icon. Actually, we probably need to look up the icon according to
the icon theme spec again ...

Anyway, this bug doesn't exist in the community yet really since
#91686 hasn't been resolved. Making this bug depend on #91686.
Comment 3 Calum Benson 2002-09-11 12:06:20 UTC
Hmm... which launcher icons, Mark?  On Solaris it works fine for all
the other launcher icons on the Application and panel menus.  (The
Actions menu works fine too, but it's all stock icons).

Oddly enough, though, on my RH7.2 box the top level Application menu
icons don't resize either, but the Add to Panel submenu icons do. 
(The sub-sub-menu icons don't though, as in the original report
above!).

Raj also sees this problem on his RH7.1 box, both with the most recent
icon-sizing sun-patch.  But IIRC Brian told me it worked fine on Sun
Linux.  Anyone have any ideas what might be causing the discrepancy
between the platforms? 
Comment 4 Calum Benson 2002-09-11 12:10:29 UTC
Oh hang on, the Add to Panel submenu icons are all stock icons too. 
So it looks like Mark is right-- none of the menu launcher icons are
reszing for me or for Raj on Linux.

This doesn't explain why it works fine (bar the third-level icons) on
Solaris, though ... what's going on there?!
Comment 5 Mark McLoughlin 2002-09-11 23:40:01 UTC
strange ...

you're right about the Actions menu being stock icons of course -
updating the title to reflect that
Comment 6 Calum Benson 2002-10-01 11:05:07 UTC
I now see similar but different behavior with Owen's icon sizing
patch, on both RH7.2 and Solaris:

- Change to a large font theme (e.g. LargePrint), all icons on the
panel menus except the ones on the top level of the Applications menu
get bigger
- Change back to default theme (say); none of the icons on panel menus
get smaller again.

Can anybody else confirm they're seeing this too?
Comment 7 Calum Benson 2002-10-01 14:59:19 UTC
All these problems seems to be rectified with Owen's fix (on RH7.2
anyway, haven't tried on Solaris yet), now that the accessible themes
are updated to specify 'gtk-dnd' rather than 'dnd' in their gtkrc files.

Mark, suggest you test this yourself with latest gnome-themes...
assuming you're happy with the results we can close this one.
Comment 8 Calum Benson 2002-10-01 17:00:54 UTC
I take it back, bug #94610 was masking this one :/   I still see that
various icons on the Applications menu (all top-level ones, plus those
on the Accessories submeu) don't resize when switching to a LargePrint
theme, yet all the other icons on all other panel menus do.
Comment 9 Calum Benson 2002-10-01 17:21:12 UTC
NB at least I'm seeing the same bug consistently on RH and Solaris
now, which is good or bad depending on how you look at it :)
Comment 10 Calum Benson 2002-10-08 17:51:26 UTC
*sigh* the synchronicity didn't last long.

- In the latest Solaris nightly branded build (Oct 8th), icon sizing
works perfectly, including on the Applications menu.

- In the latest Solaris stable build (11), which also has Owen's
complete icon sizing fix in it, John showed me the Apps menu problem
*plus* icon sizing not working generally in gtk when you try to go
back from large->normal icons.  On Solaris 8, build 11 is so broken
that I can't login so I can't check this for myself...

- In my hand-rolled linux build, last updated Oct 7th, I see the
Applications menu problem, but icon sizing works fine everywhere else.

Brian N., Shane, everyone, can you please try this on as many
different builds/platforms as possible and try and detect a pattern
because it's driving me round the twist :)
Comment 11 Calum Benson 2002-10-09 10:15:16 UTC
I withdraw my remark about it "working perfectly" in the nightly,
too... the Applications menu works perfectly, but the Add to Panel
submenu doesn't...
Comment 12 Shane O'Connor 2002-10-10 14:15:33 UTC
I've tried this on Solaris 9 with build11:-

o change to HighContrastLargePrint theme
o change back to default theme

Result
-------
The following icons do not resize back to default (i.e. they retain
large icons)
- All CDE Menu
- All Actions Menu
- Most of the  Right-click Panel menu 
	o main pop-up menu and 1st sub-menu retain large icons
	o 2nd sub-menu has small icons with the exception of the 
	CDE Menu under "Add to Panel:Launcher from Menu"


I also noticed that now if a "Lock" button is added to or already
exists on the panel when I right-click on the lock button the pop-up
menu is oversized (even though no icons are displayed).

Restarting gnome-panel will return to the default.
Comment 13 padraig.obriain 2002-10-23 07:42:40 UTC
In addition to the problems reported by Shane, I have noticed that
mneu items do not resize even when the icons do.
Comment 14 padraig.obriain 2002-10-24 10:56:06 UTC
The LargePrint theme specifies a value for gtk-icon-sizes but the
Default theme does not.

When one witches from LargePrint theme to Default theme the
gtk-icon-sizes property og GtkSettings is not updated, or at least no
notification of the update is emitted. So the gtk-icon-sizes for
LargePrint continue to be used.

Transferring to gtk+ for help on evaluation.
Comment 15 padraig.obriain 2002-10-24 12:00:07 UTC
This behaviour seems to be what bug 94610 fixes. I need to test with a
version with the fix for 94610.
Comment 16 padraig.obriain 2002-10-24 14:16:11 UTC
I have applied the changes for bug 94610 to my version of GTK+ and now
the panel does not obey the LargePrint theme at all.
Comment 17 Owen Taylor 2002-10-24 14:24:47 UTC
Padraig - you probably don't have a sufficiently new version
of Pango; you need Pango-1.0.5 or Pango-1.1.2, or current
CVS of either branch.
Comment 18 padraig.obriain 2002-10-24 14:48:09 UTC
The pango I have is from pango-1-0 branch as of October 15th so is
pango 1.0.5 +.

What made you suspect that pango may be the problem?

Comment 19 Owen Taylor 2002-10-24 16:14:59 UTC
There was a Pango bug that caused problems for the icon
size code.

If that's not it, I don't have any ideas. The icon theme size
switching worked well for me in fairly extensive testing.

I haven't tested things with the panel menus -- it is not
unlikely that the panel may have panel-specific problems in
this area that will have to be addressed in the panel..

As long as it works with testgtk, I don't think this bug
should be assigned to gtk+.
Comment 20 Owen Taylor 2002-10-25 16:24:27 UTC
Reassigning back to the panel
Comment 21 padraig.obriain 2002-10-26 11:18:39 UTC
I have corrcted my application of the changes for bug 94610 and this
bug does not now occur.

I am closing this bug as a duplicate of bug 94610.

*** This bug has been marked as a duplicate of 94610 ***
Comment 22 Calum Benson 2002-11-08 15:20:14 UTC
Just installed Sun build fcs-02 and this problem is still occurring. 
(It didn't happen for me in fcs-01, although its appearance and
disappearance was always kind of random between builds so I'm not sure
that counts for anything...)
Comment 23 padraig.obriain 2002-11-11 17:12:35 UTC
Created attachment 12227 [details] [review]
Proposed patch
Comment 24 Vincent Untz 2002-11-11 18:01:52 UTC
adding some keywords.
Comment 25 Mark McLoughlin 2002-11-11 18:36:14 UTC
Padraig: patch looks fine - feel free to commit.
Comment 26 padraig.obriain 2002-11-12 09:38:36 UTC
Patch applied.
Comment 27 bill.haneman 2003-04-03 15:22:57 UTC
I think this bug may still be alive, I am still seeing it.
Marking NEEDINFO while I confirm on HEAD.
Comment 28 Mark McLoughlin 2003-04-03 23:20:38 UTC
Bill, please don't do things like this until you've confirmed that the
bug hasn't been fixed.

Also, if you do confirm this and re-open, please re-state exactly what
the problem you're seeing now is. Thanks.
Comment 29 Calum Benson 2003-04-04 11:30:42 UTC
I can confirm that this is still a problem, see attached screenshot
from yesterday's build from HEAD, showing that with the
HighContrastLargePrint gtk theme selected, only the KDE Menu icon on
the Applications menu is correctly scaled.
Comment 30 Calum Benson 2003-04-04 11:31:33 UTC
Created attachment 15461 [details]
Screenshot showing menu icons not scaling properly
Comment 31 Calum Benson 2003-05-13 10:36:27 UTC
A couple of different people have spent time on this one now without
any success, and it's a pretty obvious/critical bug for
accessibility... trouble is it doesn't behave consistently, which
might point to a nasty race condition or something.  Anyone interested
in many free pints at GU4DEC, please try to fix this one ASAP!!
Comment 32 Mark McLoughlin 2003-05-13 14:09:07 UTC
(Viewers be warned: getting free pints out of scottsmen is
historically more than a little difficult :-)
Comment 33 padraig.obriain 2003-05-15 13:11:24 UTC
Does this problem occur if a therme is chosen in the Theme Preferences
window ot does it only happen when the Theme Details window is used?
Comment 34 padraig.obriain 2003-05-22 12:36:30 UTC
When the theme is changed using the Controls tab in the Theme Details
window the function icon_theme_changed, the signal handler for
"changed"signal on a GnomeIconTheme is not called.
Comment 35 padraig.obriain 2003-05-22 13:07:26 UTC
The Controls theme controls the appearance of the CDE Menu Icon as it
is a stock icon. The Icons Theme controls the appearance of the other
icons in the Application menu. If the Icons theme is updated the other
icons grow in size. 

One must also change the font size manually.

I do not think that this is a bug in gnome-panel.

I would regard this as a usability bug in gnome-theme-manager.
Comment 36 bill.haneman 2003-06-04 11:57:13 UTC
Hi guys:

"RESOLVED" doesn't capture the status of this horrible bug IMO.  It
seems to me that the end-user behavior is still badly broken.  Is that
not right?

If so, please open new high-priority bug, or transfer this one, but
don't just leave this closed as if there was never a problem (i.e.
NOTABUG), that's bogus.
Comment 37 padraig.obriain 2003-06-04 12:05:13 UTC
I will open a new bug.
Comment 38 padraig.obriain 2003-07-21 13:27:18 UTC
The bug I opened is 114393.