After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 91785 - can't compile pango-utils.c for cygwin
can't compile pango-utils.c for cygwin
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.0.x
Other Windows
: Normal normal
: ---
Assigned To: Owen Taylor
Owen Taylor
Depends on:
Blocks:
 
 
Reported: 2002-08-27 13:38 UTC by Masahiro Sakai
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Masahiro Sakai 2002-08-27 13:38:56 UTC 
pango-utils.c uses G_OS_WIN32 as the condition of including
windows.h. But the condition should be G_PLATFORM_WIN32
when we use G_WIN32_DLLMAIN_FOR_DLL_NAME. Because cygwin
also needs windows.h to use G_WIN32_DLLMAIN_FOR_DLL_NAME,
and G_OS_WIN32 isn't defined on cygwin.

But for now dll_name isn't used on Cygwin,
thus I'm using following patch.

--- pango/pango-utils.c.orig	2002-02-10 14:53:40.000000000 +0900
+++ pango/pango-utils.c	2002-08-26 03:27:56.000000000 +0900
@@ -637,7 +637,9 @@
 
 /* DllMain function needed to tuck away the DLL name */
 
+#ifdef G_OS_WIN32
 G_WIN32_DLLMAIN_FOR_DLL_NAME(static, dll_name)
+#endif
 
 
 /**
Comment 1 Owen Taylor 2002-08-27 14:30:44 UTC 
Can you look at this, Tor?
Comment 2 Tor Lillqvist 2002-09-04 17:37:36 UTC 
Looks fine. The dll name isn't needed on Cygwin, where one presumably 
wants to use compile-time paths, like on other Unixes. Patch applied 
to HEAD and pango-1-0.