After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 91654 - gtkfilesel.c shouldn't include <winsock.h> on Cygwin
gtkfilesel.c shouldn't include <winsock.h> on Cygwin
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.0.x
Other Windows
: Normal normal
: ---
Assigned To: Tor Lillqvist
Tor Lillqvist
Depends on:
Blocks:
 
 
Reported: 2002-08-25 17:45 UTC by Masahiro Sakai
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Masahiro Sakai 2002-08-25 17:45:27 UTC 
Cygwin has its own gethostname().
Thus including <winsock.h> conflicts with it.

--- gtk+-2.0.6/gtk/gtkfilesel.c~	2002-06-16 13:02:28.000000000 +0900
+++ gtk+-2.0.6/gtk/gtkfilesel.c	2002-08-19 12:58:08.000000000 +0900
@@ -51,7 +51,7 @@
 #include <windows.h>
 #undef STRICT
 #endif /* G_OS_WIN32 || G_WITH_CYGWIN */
-#ifdef HAVE_WINSOCK_H
+#if defined(HAVE_WINSOCK_H) && !defined(G_WITH_CYGWIN)
 #include <winsock.h>		/* For gethostname */
 #endif
Comment 1 Tor Lillqvist 2002-08-25 20:31:02 UTC 
Patch applied to HEAD and gtk-2-0.