GNOME Bugzilla – Bug 91531
gnome-session login sound plays even if disabled
Last modified: 2006-07-26 13:22:40 UTC
See patch attached to https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=71664
Hmm, the patch is a bit too simplistic I think. You could get to that case if the user has configured a certain sound for login but it can't be located. In that case you *do* want to fall back to the system sound.
Any news on this bug? It's been open for 2 years!
Any news on this bug? It's been open for 4 years! The Redhat patch may have been "simplisitic", but it certainly solved the problem. One way is noticibly broken while the other is certainly a corner case. Please apply this _one line_ patch before release of 2.14!
Created attachment 62258 [details] [review] Improved login sound patch. The following test cases have been accounted for in this patch: Default login sound. No sound. Different sound. Different sound, not found absolute filename. Different sound, not found relative filename. In the file not found conditions, the default login sound is played. In the other conditions, the expected behavior occurs.
Created attachment 65095 [details] [review] patch used by the Ubuntu package The patch from redhat doesn't work if you have a default system sound defined I've used that patch with the Ubuntu package, it works fine on my box. An other way would be to modify load_login_sample_from() to return an int and make a case for "key with no value" then
I committed another patch, without a global variable.