After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 90932 - Remove overly small default size for the icon selection button
Remove overly small default size for the icon selection button
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
2.2.x
Other Solaris
: High normal
: 2.6.0
Assigned To: Control-Center Maintainers
Control-Center Maintainers
AP4
Depends on:
Blocks:
 
 
Reported: 2002-08-16 09:48 UTC by Muktha
Modified: 2005-12-31 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (943 bytes, patch)
2003-06-12 14:31 UTC, Muktha
needs-work Details | Review
Proposed patch for setting the description in the glade file (1.10 KB, patch)
2003-06-13 05:06 UTC, Muktha
committed Details | Review
Proposed patch to fix issue 5 (520 bytes, patch)
2003-06-13 06:11 UTC, Muktha
committed Details | Review

Description Muktha 2002-08-16 09:48:13 UTC
The main window of control-centre where the icons (Accessibility, Advanced,
Background etc) are placed is not theme compliant. The background and the
foreground color does not change when HighContrast, HighContrastLargePrint,
HighContrastLargePrintInverse, LowContrastLargePrint themes are used.

Following are few other small issues:

1. In the  'Keyboard Preferences' dialog (under Keyboard), the label
   'Speed' is repeated. From accessibility perspective, it is better to use
   unique labels.
   In this case, the labels can be either changed to 'Repeat keys speed:'
   and 'Cursor Blinks speed:' or the accessible description for the
   controls can be set as 'Speed of repeat keys' and 'Speed of cursor
   blinks'.

2. In the 'CD Database Preferences' dialog (under Advanced->CD Database),
   the label 'Hostname' is repeated. I'm not sure if it's possible to
   change the label in this case. I guess, the accessible description can
   be something like 'Hostname of other server'.

3. In 'Add File type' dialog (under Advanced->File types and programs), the
   labels 'Description', 'MIME Type', 'Category', 'Viewer Component',
   'Default Action' and 'Program to run' should end in a colon.
   
   In the 'Add Service' dialog, the labels 'Description', 'Protocol' and
   'Program' should end in colon.

4. In 'XScreen saver'(under settings) the labels 'Count', 'Duration',
   'Speed', and 'No. of color' should have a colon.

5. In the 'Add File type' dialog (under File types and programs), the label
   'No Icon' on the icon button is not completely visible when larger font
   is used.
Comment 1 Luis Villa 2002-08-30 20:15:43 UTC
Muktha- do you mean in gnome-control-center --use-shell? That's really
basically a deprecated interface....
Comment 2 Muktha 2002-09-02 04:23:42 UTC
Yeah, that is the interface which is not theme compliant. Will this
interface be replaced with something else??
Comment 3 Luis Villa 2002-09-03 21:56:51 UTC
The nautilus interface that comes up when one runs
'gnome-control-center' is the current, maintained interface.
Comment 4 Andrew Sobala 2002-10-31 19:33:00 UTC
This bug is 2 parts:

o --use-shell bugs
o various capplet bugs
Comment 5 Luis Villa 2002-11-07 14:36:23 UTC
SPAM as discussed last night. Search for 'SPAM as discussed last night' to catch
these all and delete them. :) 
Comment 6 Shane O'Connor 2002-11-14 15:21:52 UTC
Luis, if gnome-control-center --use-shell is not the supported
interface should we not kick this bug to the curb? i.e., NOTGNOME?
Comment 7 Andrew Sobala 2002-11-14 17:48:32 UTC
No, because

a) we are distributing a --use-shell enabled control center, so it is
therefore sort-of supported
b) there are capplet bugs in here that need to be addressed
Comment 8 Calum Benson 2003-04-03 14:58:22 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 9 Kjartan Maraas 2003-04-29 22:27:37 UTC
Maybe submiting a patch to do the suggested changes would be nice.
Comment 10 Muktha 2003-06-12 14:31:42 UTC
Created attachment 17488 [details] [review]
Proposed patch
Comment 11 Muktha 2003-06-12 14:35:09 UTC
The above patch sets the accessible descriptions for keyboard
preferences dialog. Fixes issue 1.
Comment 12 Jody Goldberg 2003-06-12 15:01:01 UTC
Please do not apply that patch.
The right solution would be to add the information to the glade file.
Comment 13 Muktha 2003-06-13 05:06:21 UTC
Created attachment 17501 [details] [review]
Proposed patch for setting the description in the glade file
Comment 14 Muktha 2003-06-13 06:10:04 UTC
Verified in the latest sources from head. The problem of labels
missing colons in the file types and programs capplet no longer
exists. Issue 3 has been fixed.

Attaching a patch to fix issue 5 - to make the lable 'No Icon' visible
when a larger font is selected.
Comment 15 Muktha 2003-06-13 06:11:33 UTC
Created attachment 17504 [details] [review]
Proposed patch to fix issue 5
Comment 16 Murray Cumming 2003-06-30 17:44:46 UTC
Added PATCH keyword so this shows up on radar.
Comment 17 Calum Benson 2003-08-07 16:08:18 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 18 Jonathan Blandford 2003-08-12 19:23:04 UTC
Issue 5 is against libgnomeui.  Can you file a separate bug for that
issue against that module.  In general, please file separate bugs for
each issue.  It's a lot easier to deal with that way.
Comment 19 Jody Goldberg 2004-02-17 22:31:29 UTC
I'll punt the patch to libgnomeui it seems small enough to go in.
Comment 20 Calum Benson 2004-10-21 16:46:17 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 21 Kjartan Maraas 2005-05-10 22:57:38 UTC
The patch in comment #15 still hasn't been applied. Was the patch against
gnome-control-center ever filed against that product in addition to sitting in here?
Comment 22 Kjartan Maraas 2005-07-01 16:22:40 UTC
Commited the libgnomeui part. Moving back to control-center.
Comment 23 Rodrigo Moya 2005-10-24 16:02:16 UTC
g-c-c part committed for 2.13.x. Anything left?
Comment 24 Sebastien Bacher 2005-12-31 16:50:29 UTC
The patches have been commited, closing as fixed. Feel free to reopen if you still have an issue with that