After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 90928 - Enable rename option for formattable media desktop icon.
Enable rename option for formattable media desktop icon.
Status: RESOLVED INVALID
Product: nautilus
Classification: Core
Component: Desktop
2.0.x
Other Solaris
: High normal
: ---
Assigned To: Rajeev Karale
Nautilus Maintainers
Depends on:
Blocks: 105949
 
 
Reported: 2002-08-16 09:36 UTC by Rajeev Karale
Modified: 2005-08-15 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for bugtrack bug 4711207 (6.14 KB, patch)
2002-08-16 12:55 UTC, Rajeev Karale
none Details | Review
patch fixes first issue mentioned above. (1.01 KB, patch)
2003-01-22 15:28 UTC, Narayana Pattipati
none Details | Review
give out an error if the label is >8 characters (9.92 KB, patch)
2003-01-22 15:29 UTC, Narayana Pattipati
none Details | Review
patch disables rename for pcfs file system media. (9.17 KB, patch)
2003-01-22 15:30 UTC, Narayana Pattipati
none Details | Review
Patch which provides renaming functionality to removable media. (11.73 KB, patch)
2003-05-03 13:29 UTC, Narayana Pattipati
none Details | Review
patch with review comments incorporated from Campd (10.73 KB, patch)
2003-07-03 16:03 UTC, Narayana Pattipati
none Details | Review

Description Rajeev Karale 2002-08-16 09:36:36 UTC
This is SOLARIS specific RMM bug.
The right click on madia icon has got Rename disabled.
It should be enabled since solaris allows renaming(labeling) of zip/jaz 
and floppy media.
Comment 1 Rajeev Karale 2002-08-16 12:55:17 UTC
Created attachment 10530 [details] [review]
Fix for bugtrack bug 4711207
Comment 2 Luis Villa 2002-11-21 17:58:24 UTC
Is this applied to Sun's branch? 
Comment 3 Narayana Pattipati 2003-01-22 15:24:05 UTC
Some issues were found with the above patch while testing rename
functionality on various media like Floppy, zip, cdrom. The issues
are:

1. Rename for Unformatted should be disabled.

2. An error should be given out if the label length given is more 
   than 8 characters.

3. We should differenciate the labling on different kinds of file
systems. For PCFS, we disable rename because, there is no proper
command to label a pcfs media.

I will attach separate patches created on the earlier patch attached
for all the three issues in that order. These three patches should be
applied in the same order again. I can create a consalidated patch for
all the above issues and the original patch given if you are ready to
take the code changes.
Comment 4 Narayana Pattipati 2003-01-22 15:28:57 UTC
Created attachment 13750 [details] [review]
patch fixes first issue mentioned above.
Comment 5 Narayana Pattipati 2003-01-22 15:29:54 UTC
Created attachment 13751 [details] [review]
give out an error if the label is >8 characters
Comment 6 Narayana Pattipati 2003-01-22 15:30:51 UTC
Created attachment 13752 [details] [review]
patch disables rename for pcfs file system media.
Comment 7 Narayana Pattipati 2003-05-03 13:06:01 UTC
Hi Campd,

I have condensed the patches related to 'renaming' functionality in
removable media and created a single patch against HEAD. 

The patch provides renaming functionality to the removable media based
on certain conditions like:
    i. Protected media should not have renaming option.
    ii. unformatted media should not have renaming option
    iii. media with pcfs file system should not have renaming option
as there is no labling support yet.
    iv. And while renaming, the media needs to be unmounted, labeled
with the new name and then re-mounted. 

All the code changes related to this patch are kept under SOLARIS
specific flags. Linux build is successful with the patch.

Could you please review the patch?
Comment 8 Narayana Pattipati 2003-05-03 13:29:38 UTC
Created attachment 16232 [details] [review]
Patch which provides renaming functionality to removable media.
Comment 9 Narayana Pattipati 2003-07-03 15:56:44 UTC
Hi Campd,

Thanks for the review of the above patch. I am attching a new patch
with the review comments (which were given offline) incorporated. 

Thanks,
Narayana
Comment 10 Narayana Pattipati 2003-07-03 16:03:59 UTC
Created attachment 18016 [details] [review]
patch with review comments incorporated from Campd
Comment 11 Kjartan Maraas 2003-10-30 22:04:46 UTC
Should this get into 2.5.x now?
Comment 12 alexander.winston 2004-01-03 18:25:23 UTC
Upgrading the priority level to High because of the patches attached.
Comment 13 alexander.winston 2004-01-28 05:10:07 UTC
+ Adding the portability keyword as well
Comment 14 Narayana Pattipati 2004-02-21 07:42:07 UTC
This patch is for providing rename options for removable media on
Solaris. It does not apply on HEAD anymore, as volume management and
file manager code has changed in HEAD. Hence closing the bug. Will
raise a new bug if the same patch is required for Solaris running
HEAD/2.6.