GNOME Bugzilla – Bug 90928
Enable rename option for formattable media desktop icon.
Last modified: 2005-08-15 01:35:42 UTC
This is SOLARIS specific RMM bug. The right click on madia icon has got Rename disabled. It should be enabled since solaris allows renaming(labeling) of zip/jaz and floppy media.
Created attachment 10530 [details] [review] Fix for bugtrack bug 4711207
Is this applied to Sun's branch?
Some issues were found with the above patch while testing rename functionality on various media like Floppy, zip, cdrom. The issues are: 1. Rename for Unformatted should be disabled. 2. An error should be given out if the label length given is more than 8 characters. 3. We should differenciate the labling on different kinds of file systems. For PCFS, we disable rename because, there is no proper command to label a pcfs media. I will attach separate patches created on the earlier patch attached for all the three issues in that order. These three patches should be applied in the same order again. I can create a consalidated patch for all the above issues and the original patch given if you are ready to take the code changes.
Created attachment 13750 [details] [review] patch fixes first issue mentioned above.
Created attachment 13751 [details] [review] give out an error if the label is >8 characters
Created attachment 13752 [details] [review] patch disables rename for pcfs file system media.
Hi Campd, I have condensed the patches related to 'renaming' functionality in removable media and created a single patch against HEAD. The patch provides renaming functionality to the removable media based on certain conditions like: i. Protected media should not have renaming option. ii. unformatted media should not have renaming option iii. media with pcfs file system should not have renaming option as there is no labling support yet. iv. And while renaming, the media needs to be unmounted, labeled with the new name and then re-mounted. All the code changes related to this patch are kept under SOLARIS specific flags. Linux build is successful with the patch. Could you please review the patch?
Created attachment 16232 [details] [review] Patch which provides renaming functionality to removable media.
Hi Campd, Thanks for the review of the above patch. I am attching a new patch with the review comments (which were given offline) incorporated. Thanks, Narayana
Created attachment 18016 [details] [review] patch with review comments incorporated from Campd
Should this get into 2.5.x now?
Upgrading the priority level to High because of the patches attached.
+ Adding the portability keyword as well
This patch is for providing rename options for removable media on Solaris. It does not apply on HEAD anymore, as volume management and file manager code has changed in HEAD. Hence closing the bug. Will raise a new bug if the same patch is required for Solaris running HEAD/2.6.