After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 90753 - Gtk::Scale methods use int instead of bool (and aren't documented)
Gtk::Scale methods use int instead of bool (and aren't documented)
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
2.0
Other other
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2002-08-14 16:47 UTC by Ole Laursen
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes int to bool int set/get_draw_value and adds documentation (5.05 KB, patch)
2002-08-14 16:48 UTC, Ole Laursen
none Details | Review

Description Ole Laursen 2002-08-14 16:47:55 UTC
The two methods in question are:

  void set_draw_value (int draw_value)
  int get_draw_value () const

However, the GTK+ documentation says

  void gtk_scale_set_draw_value (GtkScale *scale, gboolean draw_value);

   Specifies whether the current value is displayed as a string next
   to the slider. 

so integer values doesn't make any sense. I'm attaching a patch for
correcting this - the patch also adds more documentation and fixes some of
the existing. I haven't documented calc_digits, though, since I'm not quite
sure what is is supposed to do.

The patch shouldn't cause any real API change because of the implicit
conversion rules between bool and int, but I guess it is important to
change before the ABI freeze. (Note that the patch hasn't been syntax
checked since I couldn't get the CVS version of gtkmm-1.3 to compile.)
Comment 1 Ole Laursen 2002-08-14 16:48:46 UTC
Created attachment 10488 [details] [review]
Changes int to bool int set/get_draw_value and adds documentation
Comment 2 Murray Cumming 2002-08-15 07:06:00 UTC
Thanks. calc_digits_() is proctected anyway - the _ suffix shows that
it is for "internals" anyway.

If you can't build from cvs then tell us about the problem.