GNOME Bugzilla – Bug 90634
Media desktop icons on solaris not showing correct protection options
Last modified: 2005-08-15 01:51:36 UTC
This is removable media bug for RMM(removable media manager) on solaris only. Put a media into drive. You will get the media icon on desktop. On right click we should get the following options menu items. 1. For all media types we should get "Help" as one of the menu item on right click. 2. For zip "Write Protect" and "Read Write Protect" for unproteced media. "Disable Protection" for protected media. 3. Right click on nautilus desktop and Select Disks menu. It should display "Floppy" as one of the menu item of Disks menu. On clicking on to that it should mount Floppy.
Created attachment 10457 [details] [review] Patch which fixes above problems is attached.
Patch will fix following bugs in Bugtrack. 4711021 4711031 4722691
Rajeev: is this somehow different from the patch/bug at 90232?
Hi Dave/Alex, Did you get a chance to look at this Solaris Removable Media Manager related nautilus patch? This is one of the Removable Media Manager related nautilus patches which we put into bugzilla. The other bugs which have related patches are: 90928, 90232, 90942, 95041. Our QA team has been doing testing of all the patches for quite a long time. Infact, they have done some 6-7 rounds of testing on the patches for Solaris. As a whole, they are all working well, except for few minor issues. We have fixes for those issues also. But I did not put them into bugzilla yet. If you are OK with the existing patches, and ready to take, I can re-create the patches(in logical order) for each of the bugs against HEAD or branches and put in bugzilla. Also we have built these patches successfully on Linux. If you get some time, could you please review these patches and give your comments? Thanks, Narayana.
User should not be able to protect an unformatted media. So I will put up a patch which fixes this issue. The patch may not apply directly on the above patch. I will create a consalidated patch one both of them are approved.
Created attachment 14284 [details] [review] patch disables protection options for unformatted media
Hi Dave, I had made a single patch against HEAD for this bug by combining all related patches. I will attach a patch shortly. The patch does the following: - Provide Help menu and help functionality for removable media - Provide Protection related menus and protection functionality for removable media - Also code changes have been made to look for removable media manager applications under $prefix/lib. This is the new path for removable media manager applications. Please review the patch.
Created attachment 16233 [details] [review] Consolidated patch for this bug.
Campd, I am attaching a new patch with the review comments you have given on IRC. Thanks, Narayana
Created attachment 20529 [details] [review] patch with review comments incorporated
Anyone want to review these patches or comment on them further?
This patch seems to no longer apply cleanly at all: aew@duende:~/Projects/GNOME/CVS/nautilus$ patch --strip=1 < /home/aew/showattachment.cgi patching file ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file ChangeLog.rej patching file src/file-manager/Makefile.am Hunk #1 FAILED at 14. 1 out of 1 hunk FAILED -- saving rejects to file src/file-manager/Makefile.am.rej patching file src/file-manager/nautilus-desktop-icon-view-ui.xml Hunk #1 FAILED at 8. Hunk #2 FAILED at 84. 2 out of 2 hunks FAILED -- saving rejects to file src/file-manager/nautilus-desktop-icon-view-ui.xml.rej patching file src/file-manager/fm-desktop-icon-view.c Hunk #1 FAILED at 60. Hunk #2 succeeded at 72 (offset -1 lines). Hunk #3 FAILED at 117. Hunk #4 succeeded at 612 with fuzz 2 (offset -14 lines). Hunk #5 FAILED at 635. Hunk #6 FAILED at 652. Hunk #7 FAILED at 666. Hunk #8 FAILED at 709. Hunk #9 FAILED at 737. Hunk #10 FAILED at 749. Hunk #11 succeeded at 692 with fuzz 1 (offset -356 lines). Hunk #12 FAILED at 735. Hunk #13 FAILED at 782. Hunk #14 FAILED at 803. Hunk #15 FAILED at 852. Hunk #16 FAILED at 874. Hunk #17 FAILED at 896. Hunk #18 FAILED at 992. Hunk #19 FAILED at 1041. 16 out of 19 hunks FAILED -- saving rejects to file src/file-manager/fm-desktop-icon-view.c.rej
This patch is for fixing removable media related problem in Solaris and does not apply on HEAD anymore. Hence closing the bug. Will raise a new bug if the same problem is found to be there on Solaris running HEAD/2.6.