After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 90519 - IfsCompose's design preview needs context sensitive cursors
IfsCompose's design preview needs context sensitive cursors
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2002-08-12 07:58 UTC by Maurits Rijk
Modified: 2005-07-26 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Maurits Rijk 2002-08-12 07:58:59 UTC
In the GFlare plug-in the mouse cursor should be changed when it enters the
preview window so the user has some visual feedback to make it more obvious
that you can click in the preview.
Comment 1 Erik Johansson 2003-07-24 18:53:43 UTC
Visual feedback would indeed be nice (Hey, I didn't know this =), if
its not too much work it would be nice to have in 2.0.
Changing target milestone to 2.0 in response to mail sent by David
Neary on the gimp-developer list.
Comment 2 Henrik Brix Andersen 2003-08-22 20:09:26 UTC
Changed the short summary to something more general since this bug
report also applies to the following plug-ins:
GFlare
IWarp
Supernova
FlareFX
IfsCompose

The following plug-ins already indicate (by cursor change) that the
preview is clickable:
GFig
Fractal Explorer

The following plug-ins also change the cursor but clicking the preview
doesn't do anything(?):
Lighting Effects
Map to Object
Comment 3 Dave Neary 2003-11-25 13:03:01 UTC
Bumping to 2.2. 

Dave.
Comment 4 Maurits Rijk 2004-10-13 06:35:04 UTC
Should this be part of the new plug-in preview widget?
Comment 5 Sven Neumann 2004-10-13 09:30:14 UTC
Maurits, I don't understand your question. The plug-ins we talk about do special
things with the preview. Of course the visual feedback cannot be part of the
preview widget since the preview widget doesn't know anything about this.
Comment 6 Michael Natterer 2004-10-13 12:22:36 UTC
I just tried to fix this for nova and flarefx, but it appears impossible
because GimpPreview and friends have their own idea about the preview
area's cursor.

Will probably need a GimpPreview API to do this.

Increasing priority because it needs an API change and thus
must be done before 2.2.
Comment 7 David Odin 2004-10-13 18:56:28 UTC
2004-10-13  DindinX  <dindinx@gimp.org>

	* libgimpwidgets/gimppreview.[ch]: added a new function to set the
	default cursor on preview: gimp_preview_set_default_cursor().

	* libgimpwidgets/gimpscrolledpreview.c: changed accordlingly.

	* plug-ins/common/flarefx.c:
	* plug-ins/common/nova.c: use this function.

	This addresses bug #90519.

Comment 8 Michael Natterer 2004-10-14 11:06:30 UTC
Resetting priority to "Normal" because the API change has been done.
Comment 9 Sven Neumann 2004-10-22 13:45:10 UTC
If someone wants to look into the remaining plug-ins. This could still be done
before 2.2. Should be an easy fix.
Comment 10 Sven Neumann 2004-10-27 14:00:20 UTC
I am not sure but I think the current choice of cursor in FlareFX, Supernova as
well as Lighting Effects (and perhaps others) is somewhat unfortunate. The hand
cursor is already used by the scrollable previews. Perhaps the crosshair cursor
(see
http://developer.gnome.org/doc/API/2.0/gdk/gdk-Cursors.html#gdk-cursor-new-for-display)
would be more appropriate here?
Comment 11 Michael Natterer 2004-10-27 15:43:30 UTC
Agreed, the hand cursor should only ever be used for moving. For picking
points the crosshair you suggested in IMHO a good choice.
Comment 12 Michael Natterer 2004-10-29 10:37:53 UTC
Fixed in CVS. Changed to FUTURE for the IfsCompose issue.

2004-10-29  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/flarefx.c
	* plug-ins/common/nova.c: changed preview cursors to GDK_CROSSHAIR.

	* plug-ins/common/iwarp.c
	* plug-ins/gflare/gflare.c
	* plug-ins/ifscompose/ifscompose.c: added GDK_CROSSHAIR preview
	cursors. Not quite perfect for IfsCompose (actually needs tool-
	and constext-sensitive cursors) but definitely better than
	before. Fixes bug #90519.
Comment 13 Sven Neumann 2005-07-26 13:38:23 UTC
So much effort for a five lines change...

2005-07-26  Sven Neumann  <sven@gimp.org>

	* plug-ins/ifscompose/ifscompose.c: change the cursor with the tool
	(bug #90519).