After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 89822 - crash while multiple quick clicks
crash while multiple quick clicks
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.0.x
Other Linux
: High critical
: ---
Assigned To: Rosanna Yuen
Gregory Leblanc
: 90905 94494 94495 96254 97452 102336 102999 103548 104936 105435 108734 117032 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-08-04 02:30 UTC by Samuel Stringham
Modified: 2012-01-31 23:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
A fix for the double-click bug #89822 in aisleriot (398 bytes, patch)
2002-09-15 01:20 UTC, Callum McKenzie
none Details | Review

Description Samuel Stringham 2002-08-04 02:24:10 UTC
Package: gnome-games
Severity: normal
Version: 2.0.1
Synopsis: crash while multiple quick clicks
Bugzilla-Product: gnome-games
Bugzilla-Component: aisleriot
BugBuddy-GnomeVersion: 2.0 (2.0.1)

Description:
lets see if anyone else can reproduce this.  Looks kind of random, but
it happened while I was double clicking on the cards really fast to send
them up home in seahaven



Debugging Information:

Backtrace was generated from '/opt/gnome2/bin/sol'

[New Thread 1024 (LWP 780)]
0x40b1a1e9 in __wait4 () from /lib/libc.so.6

Thread 1 (Thread 1024 (LWP 780))

  • #0 __wait4
    from /lib/libc.so.6
  • #1 __DTOR_END__
    from /lib/libc.so.6
  • #2 waitpid
    at wrapsyscall.c line 173
  • #3 libgnomeui_segv_handle
    at gnome-ui-init.c line 620
  • #4 pthread_sighandler
    at signals.c line 97
  • #5 <signal handler called>
  • #6 generate_press_data
    at eval.c line 88
  • #7 motion_notify_event
    at eval.c line 88
  • #8 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 82
  • #9 g_closure_invoke
    at gclosure.c line 437
  • #10 signal_emit_unlocked_R
    at gsignal.c line 2341
  • #11 g_signal_emit_valist
    at gsignal.c line 2110
  • #12 gtk_signal_emit
    at gtksignal.c line 355
  • #13 gtk_widget_event_internal
    at gtkwidget.c line 3082
  • #14 gtk_widget_event
    at gtkwidget.c line 2943
  • #15 gtk_propagate_event
    at gtkmain.c line 2088
  • #16 gtk_main_do_event
    at gtkmain.c line 1337
  • #17 gdk_event_dispatch
    at gdkevents-x11.c line 1763
  • #18 g_main_dispatch
    at gmain.c line 1617
  • #19 g_main_context_dispatch
    at gmain.c line 2161
  • #20 g_main_context_iterate
    at gmain.c line 2242
  • #21 g_main_loop_run
    at gmain.c line 2462
  • #22 gtk_main
    at gtkmain.c line 936
  • #23 main_prog
    at eval.c line 88
  • #24 gh_launch_pad
    at gh_init.c line 60
  • #25 invoke_main_func
    at init.c line 623
  • #26 scm_internal_lazy_catch
    at throw.c line 281
  • #27 scm_boot_guile_1
    at init.c line 598
  • #28 scm_boot_guile
    at init.c line 441
  • #29 gh_enter
    at gh_init.c line 70
  • #30 main
    at eval.c line 88
  • #31 __libc_start_main
    at ../sysdeps/generic/libc-start.c line 129
  • #0 __wait4
    from /lib/libc.so.6




------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-08-03 22:24 -------

Reassigning to the default owner of the component, zana@webwynk.net.

Comment 1 Ben FrantzDale 2002-08-04 04:07:34 UTC
This looks like the first report of this stack trace FWIW.
Comment 2 Samuel Stringham 2002-08-05 04:15:23 UTC
maybe this is libguile related?  I don't know.  It happened again a
couple times tonight, only when double clicking though.
Comment 3 Ben FrantzDale 2002-08-16 23:21:02 UTC
*** Bug 90905 has been marked as a duplicate of this bug. ***
Comment 4 Steven Usdansky 2002-08-24 21:02:50 UTC
Started sol from window twice.  Crashed both times as in description
with the following message:

ERROR: In procedure car:
ERROR: Wrong type argument in position 1: ()
Comment 5 Telsa Gwynne 2002-09-10 11:46:08 UTC
When I start from the command line, I get that error message when
aisleriot crashes. Almost any layout, and yes, clicking quickly
seems to be involved here, too. 

This is on a RH "null" system and with gnome-games-2.0.3-2 rpm
from RH. 
Comment 6 Jonathan Blandford 2002-09-13 20:44:48 UTC
This bug is caused when you start a move, then double click.  Doing
something like:
gconftool-2 -s /desktop/gnome/peripherals/mouse/double_click -t int 1000
should help trigger it.
Comment 7 Callum McKenzie 2002-09-14 23:39:10 UTC
It still happens with gnome-games 2.0.4, I got the above mentioned
error message just after clicking the "new game" button after a
succesful game of klondike (I had been doing a lot of double clicks
just before-hand to clear the deck and I have sometimes seen the program
crash while double clicking a lot).
Comment 8 Callum McKenzie 2002-09-15 01:20:04 UTC
Created attachment 11080 [details] [review]
A fix for the double-click bug #89822 in aisleriot
Comment 9 Callum McKenzie 2002-09-15 01:25:07 UTC
Just a few notes on the proposed fix. 

a) I don't have CVS access so no one should assume I'm going to make
sure it is applied.

b) This bug (see the patch for exactly what it was) meant that the
press_data->status field wasn't set properly for the second click.
Hence  the motion_notify_event routine in events.c was trying to call
the button-pressed routine with an empty card list. Most of the card
games don't check to see if it's empty so you have cases like in
klondike.scm where the code attempts to take it's car, hence the error
message.
Comment 10 jdhildeb 2002-09-22 03:02:26 UTC
Aisleriot was crashing quite often on my laptop due to this, whereas
it ran quite well on my desktop -- perhaps the problem is aggravated
by certain timings.

In any case, I applied to attached fix to gnome-games-2.02 sources,
and can confirm that the problem is fixed.  Please apply to CVS.
Comment 11 Callum McKenzie 2002-09-23 19:48:39 UTC
Just a quick note about how to reproduce the bug (to further encourage
application of the patch). First, get the program into a situation
where a double-click is expected to do something, for example go into
Klondike and keep clicking new until an ace appears. Perform a normal
double-click on the ace but before releasing the mouse button the
second time stop and hold it down. The moment you move the mouse the
program will crash (assuming the patch hasn't been applied).
Comment 12 Ross Burton 2002-09-24 08:36:58 UTC
I'm planning on commiting this at lunch, don't worry! :)
Comment 13 Ross Burton 2002-09-30 12:38:21 UTC
Applied to HEAD, thanks.
Comment 14 Ben FrantzDale 2002-10-16 05:25:26 UTC
*** Bug 94495 has been marked as a duplicate of this bug. ***
Comment 15 Ben FrantzDale 2002-10-16 05:26:36 UTC
*** Bug 94494 has been marked as a duplicate of this bug. ***
Comment 16 Vidar Hauge 2002-11-03 11:30:17 UTC
*** Bug 96254 has been marked as a duplicate of this bug. ***
Comment 17 Vidar Hauge 2002-11-12 04:19:12 UTC
*** Bug 97452 has been marked as a duplicate of this bug. ***
Comment 18 David Kennedy 2003-01-09 13:07:21 UTC
*** Bug 102336 has been marked as a duplicate of this bug. ***
Comment 19 Alex Duggan 2003-01-10 03:05:29 UTC
*** Bug 102999 has been marked as a duplicate of this bug. ***
Comment 20 Alex Duggan 2003-02-06 21:19:14 UTC
*** Bug 105435 has been marked as a duplicate of this bug. ***
Comment 21 Callum McKenzie 2003-06-04 09:59:43 UTC
*** Bug 108734 has been marked as a duplicate of this bug. ***
Comment 22 Callum McKenzie 2003-06-04 10:05:55 UTC
*** Bug 104936 has been marked as a duplicate of this bug. ***
Comment 23 Callum McKenzie 2003-06-04 10:09:36 UTC
*** Bug 103548 has been marked as a duplicate of this bug. ***
Comment 24 Callum McKenzie 2003-07-09 03:32:33 UTC
*** Bug 117032 has been marked as a duplicate of this bug. ***
Comment 25 Robert Ancell 2012-01-31 23:26:32 UTC
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!