After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 89568 - gst_pad_try_set_caps should return more than boolean
gst_pad_try_set_caps should return more than boolean
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal major
: 0.4.0
Assigned To: Andy Wingo
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-07-31 23:20 UTC by matt romaine
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description matt romaine 2002-07-31 23:20:26 UTC 
gstpad.c:gst_pad_try_set_caps currently only returns boolean.  The function
however will also call gst_pad_try_set_caps_func, which returns a
GstPadConnectReturn with more information.  If elements are in a READY
state and a caps nego trys to happen, even if _set_caps_func returns a
GST_PAD_CONNECT_DELAYED, gst_pad_try_set_caps (the function that called
_caps_func) will return FALSE and the pipeline will later have trouble
running (at least it does on my setup :)

could someone look at this?

thanks
Comment 1 matt romaine 2002-08-21 22:27:51 UTC 
hee's a diff on gstpad.c (bottom one is corrected version).  I sent
out a few emails about this hackish-fix, so hopefully someone read
them.  do a search for emails from me if you need to know what's going on.

1343c1343,1345
< 		GST_PAD_CONNECT_OK))
---
> 	       GST_PAD_CONNECT_OK) &&
> 	      (gst_pad_try_set_caps_func (peer, caps, TRUE) !=
> 	       GST_PAD_CONNECT_DELAYED))
Comment 2 Ronald Bultje 2002-09-09 20:21:44 UTC 
Capsnego in READY should work now (that was yet another bug), but this
still applies. gst_pad_try_set_caps() should give a GstPadConnectReturn.
Comment 3 Ronald Bultje 2002-09-10 09:11:45 UTC 
Okay, the change in API is in CVS now. gst_pad_try_set_caps returns a
GstPadConnectReturn now.