GNOME Bugzilla – Bug 88727
Tool preview icon is hardcoded
Last modified: 2004-12-22 21:47:04 UTC
The tool options tab header hardcodes its icon, thus making themes fail in its purpose: provide an unified look. The widget name seems to be GimpToolInfoPreview (inspecting with GLE module for GTK+). This widget should use a similar approach like the others, so it can be changed via gtkrc. It does not make much sense to use it as "preview" when it does not behave like Brush preview, ie.
The icon is not hardcoded, it uses the icon of the active tool. The tool icons itself are themeable.
I am theming all the app with a gtkrc that uses the theme icons or shows nothing (1*1 pixel) or shows error (image not avaliable yet). I attach that gtkrc file and a capture of the screen. Could someone tell me then why icons differ? With GLE this "icon" is not marked as GtkImage at all, all I see is a GtkHBox that has GtkLabel and GimpToolInfoPreview, and none of those make references to stock images or can expand (leaves of the tree). By toogling "visible" of GTIP I can make the "icon" disappear, but that is not what I want. Others icons are GtkImage and have the Stock ID I write in the gtkrc.
Created attachment 9995 [details] Dock and toolbox, same theme, different look
Created attachment 9996 [details] gtkrc under testing, used for the previous image
OK, it's indeed a missing feature. GimpPreview isn't yet finished. We need to add support for (stock) pixbufs.
This is now fixed in CVS: 2003-02-26 Michael Natterer <mitch@gimp.org> * app/core/gimpviewable.[ch]: added "gchar *stock_id" to the GimpViewable struct. It is used by the GUI if the get_preview() functions return NULL. Default to GTK_STOCK_DIALOG_QUESTION. * app/core/gimptoolinfo.[ch]: set the tool's stock_id. Removed the cached GdkPixbuf. Don't implement any preview function so the GUI uses the stock_id. * app/tools/tool_manager.c: removed GdkPixbuf creation, removed the #warning about the buggy way we created the pixbuf.