After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 88669 - some charsets missing in pan-charset-picker.c
some charsets missing in pan-charset-picker.c
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.13.0 betas
Other Linux
: Normal normal
: 0.13.0
Assigned To: Christophe Lambin
Christophe Lambin
: 89280 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-07-20 06:17 UTC by Martin Tomasek
Modified: 2006-06-18 04:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
2 charsets addition (581 bytes, patch)
2002-07-20 06:18 UTC, Martin Tomasek
none Details | Review

Description Martin Tomasek 2002-07-20 06:17:45 UTC
..so I added windows-1250 and UTF-8.
Comment 1 Martin Tomasek 2002-07-20 06:18:45 UTC
Created attachment 9976 [details] [review]
2 charsets addition
Comment 2 Charles Kerr 2002-07-20 13:26:54 UTC
Chris: you did the pruning of that charset list;
do these additions make sense?
Comment 3 Christophe Lambin 2002-07-20 23:10:55 UTC
I like the idea of adding utf-8 as a fallback solution .

Not too sure about windows-1250 though, since we already have
ISO-8859-2. Martin: is there a specific need to have this, or did you
add this for completeness ?
Comment 4 Martin Tomasek 2002-07-21 00:15:58 UTC
I added windows-1250, because I need to set it as default charset for
some cz.* groups.
Comment 5 Christophe Lambin 2002-07-28 22:24:51 UTC
*** Bug 89280 has been marked as a duplicate of this bug. ***
Comment 6 Christian Lohmaier 2002-07-29 00:39:54 UTC
I just realized that my approach to force pan to use utf-8 as default
was wrong :-)
pan is cleverer than I thought.. it checks for the user's
locale-charset and only if that fails uses PAN_DEFAULT_CHARSET (which
is defined in two files: pan/pan-charset-picker.c &
pan/base/pan-glib-extensions.c - I don't know why this is defined
twice, you probably can tell me :-)

With this just-gained-knowledge I hacked my pan-glib-extensions.c to
always return PAN_DEFAULT_CHARSET (set this to utf-8) to workaround
the charset-bug

But know to the real reason for this comment:
Since pan only falls back on the defined default charset when checking
the locale setting fails it makes more sense to me to set this to
utf-8 instead of latin1 (as Christophe said, it's just a
fallback-solution): Either the user has set some exotic locale -> in
this case it's very common that the user wants to use special
characters. Since it isn't sure which chars the user's gonna type it
is necessary to use utf-8 (just think of latin9 vs latin1: Euro-Sign
versus Currency-Sign, z with upside-down circumflex vs dead accent)
If the user doesn't want non-ascii characters at all theres no problem
with utf-8. ASCII stays ASCII - other user's newsreaders don't need to
know anything about utf-8.
Comment 7 Christophe Lambin 2002-07-29 20:52:46 UTC
Added these charsets to CVS for 0.12.2 and merged to HEAD.

I agree with Charles: making UTF-8 the default charset is not the way
to go.