GNOME Bugzilla – Bug 88669
some charsets missing in pan-charset-picker.c
Last modified: 2006-06-18 04:56:00 UTC
..so I added windows-1250 and UTF-8.
Created attachment 9976 [details] [review] 2 charsets addition
Chris: you did the pruning of that charset list; do these additions make sense?
I like the idea of adding utf-8 as a fallback solution . Not too sure about windows-1250 though, since we already have ISO-8859-2. Martin: is there a specific need to have this, or did you add this for completeness ?
I added windows-1250, because I need to set it as default charset for some cz.* groups.
*** Bug 89280 has been marked as a duplicate of this bug. ***
I just realized that my approach to force pan to use utf-8 as default was wrong :-) pan is cleverer than I thought.. it checks for the user's locale-charset and only if that fails uses PAN_DEFAULT_CHARSET (which is defined in two files: pan/pan-charset-picker.c & pan/base/pan-glib-extensions.c - I don't know why this is defined twice, you probably can tell me :-) With this just-gained-knowledge I hacked my pan-glib-extensions.c to always return PAN_DEFAULT_CHARSET (set this to utf-8) to workaround the charset-bug But know to the real reason for this comment: Since pan only falls back on the defined default charset when checking the locale setting fails it makes more sense to me to set this to utf-8 instead of latin1 (as Christophe said, it's just a fallback-solution): Either the user has set some exotic locale -> in this case it's very common that the user wants to use special characters. Since it isn't sure which chars the user's gonna type it is necessary to use utf-8 (just think of latin9 vs latin1: Euro-Sign versus Currency-Sign, z with upside-down circumflex vs dead accent) If the user doesn't want non-ascii characters at all theres no problem with utf-8. ASCII stays ASCII - other user's newsreaders don't need to know anything about utf-8.
Added these charsets to CVS for 0.12.2 and merged to HEAD. I agree with Charles: making UTF-8 the default charset is not the way to go.