GNOME Bugzilla – Bug 88633
Border Selection Without feathering
Last modified: 2006-06-05 18:34:18 UTC
Hello, It would be very nice to be able to border a selection without having the resulting selection feathered! The GIMP Users Manual simply states: "Selections created using Border selection are feathered" so I'm assuming there's no current option to disable this behavior. Thanks for your time! -Fredric Echols rwf@gpcom.net
Adding a toggle to make this behaviour optional sounds like a good idea for 1.3.
Bumping a bunch of enhancement requests which will not be done by the feature freeze to Future. Dave.
This can already be easily achieved by calling Select->Sharpen after bordering the selection. Does it really make sense to clutter the UI with another check button?
This is such an old enhancement request. If adding the toggle is too much clutter to the already extremely simple UI and the knowledge that Select -> Sharpen is expected, can this report be reassigned to the Help component. I was actually surprised to see that this is part of the gimp internals. After a few months of reflection and dealing with GIMP Usability, perhaps adding the toggle is not such an unreasonable suggestion.
This bug report is similar to 86279. I am adding gnome-love to the keywords.
Created attachment 66734 [details] [review] Patch to add "unfeathered" option to Selection Border This patch adds a checkbox to the <image>/Selection/Border command which toggles feathering on and off. This patch adds a boolean "feather_border" argument to the relevant core functions but hardcodes this argument to TRUE for the PDB functions so as not to alter the plugin interface. NOTE: the result of an unfeathered operation is not precisely the same as if a "Selection Sharpen" were performed after a feathered "Selection Border"; despite the PDB notes, Selection Sharpen seems to use a threshold of "127" and not "0". I haven't had time to see if there is an existing report for this disparity. The patch is relative to CVS head.
Sorry, but the patch doesn't look as if it was created against the HEAD branch from CVS. In general it looks fine, despite a number of coding style issues and the fact that the *_cmds.c files in the app/pdb directory are generated code.
The patch is ok anyway, will look into applying it.
Fixed in CVS: 2006-06-05 Michael Natterer <mitch@gimp.org> Applied slightly modified patch from saulgoode which allows to border a selection without feathering. Fixes bug #88633. * app/paint-funcs/paint-funcs.[ch] (border_region): added boolean "feather_border" parameter. * app/core/gimpchannel.[ch]: GimpChannel::border(): ditto. * app/core/gimpselection.c: changed accordingly. * app/actions/select-commands.c: added a toggle to the border dialog and pass it to gimp_channel_border(). * tools/pdbgen/pdb/selection.pdb: pass TRUE here. * app/pdb/selection_cmds.c: regenerated.