GNOME Bugzilla – Bug 87876
ModN keybindings not working
Last modified: 2015-03-24 13:00:35 UTC
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=67309 The key shortcuts capplet won't let you enter ModN bindings, but even if you use gconf-editor, the panel then doesn't work with them. The basic problem is IGNORED_MODS in global-keys.h. Instead of hardcoding this, it should be determined at runtime. Metacity has code to do this, so does eggcellrendererkeys I think.
When I say instead of hardcoding, what you want to find at runtime is num lock and scroll lock, to filter those specifically instead of all modN.
Created attachment 9851 [details] [review] use libegg functionality to fix this
Patch attached. This code has other problems though; if you change your modmap while the panel is running it will break for example. I increasingly think the right thing to do is put all global keybindings in the window manager. Also, panel needs to parse its keybinding gconf keys with egg_accelerator_parse_virtual(), this patch doesn't do that. This would let us have default bindings with <Super> or <Meta> in them. eggaccelerators.h added in the patch does contain this function.
Havoc, feel free to commit this. I don't know enough about this to offer any decent comments - I assume you do, though :-) Also, feel free to plaster a big FIXME across the top of global-keys.c listing what needs to be fixed and I (or someone else) will hopefully get around to researching and fixing it.
ping? havoc? did you commit?
Created attachment 10587 [details] [review] Patch to apply to HEAD
Just applied to gnome-2-0 but not HEAD. For HEAD some multihead stuff needs sorting out I think, patch doesn't quite apply. Leaving patch attached here to sort out for 2.2.
Oh, now I see - that's why it wasn't applied to HEAD ... Closing 'cause I merged it in a couple of weeks ago
verified in suns build11 (cvs oct 1st) - using <Mod4> in keybindings in gconf-editor works