GNOME Bugzilla – Bug 87729
default currency in book (Reports always in USD)
Last modified: 2018-06-29 20:13:51 UTC
Hi, all reports are always in USD, even if the default currency is e.g. EUR. Changing the currency of the report via options work. How to reproduce: - Open a new File - Change the default currency to EUR - Create a new account - add some money to the account - Try the "Welcome Extravaganza" Report The account summary is in USD. The bug was not in gnucash 1.6.6. regards, christian
The was triggered by the patch below. The patch changed where the default currency used in reports comes from. In gnucash-1.6.x it was the global gnucash default currency and now it depends on the locale settings. But this doesn't work. gnucash$ cvs diff -r 1.1 -r 1.2 src/report/report-system/options-utilities.scm Index: src/report/report-system/options-utilities.scm =================================================================== RCS file: /home/cvs/cvsroot/gnucash/src/report/report-system/options-utilities.scm,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- src/report/report-system/options-utilities.scm 17 Aug 2001 00:43:31 -0000 1.1 +++ src/report/report-system/options-utilities.scm 3 Oct 2001 10:07:43 -0000 1.2 @@ -197,7 +197,7 @@ pagename name-report-currency sort-tag (N_ "Select the currency to display the values of this report in.") - (gnc:default-currency)))) + (gnc:locale-default-iso-currency-code)))) ;; These are common options for the selection of the report's ;; currency/commodity. The problem was discussed on the mailinglist and Derek proposed the following: > > Perhaps the default currency should be stored in the book > > instead of some global option? > > IMHO this would be the best solution... Well, we now have this nice "options" interface to do this :) The data would be stored in the Book KVP, but edited via a nice options dialog out of File -> Properties. Someone would just need to move the location where this menu option is created, and add a new page to set default currencies et. al. And then change the report-options code.
According to Derek's proposed solution, I implemented the "default currency option stored in the book". The global "default currency" still exists... The attached patch works fine (for me ;-) ), all reports are done in the book default currency. regards, christian
Created attachment 10233 [details] [review] implements "default currency" per book
The reports always being in USD was solved by fixing 89471. Now reports will follow the locale. There is still the question of the default currency, however, so I'm going to keep this bug open until we figure out how that should work.
<_chkr_> yes, the bug 87729 is solved with the changes to the other bug... (I was the reporter... ;) )
*** Bug 99364 has been marked as a duplicate of this bug. ***
*** Bug 100466 has been marked as a duplicate of this bug. ***
*** Bug 102043 has been marked as a duplicate of this bug. ***
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=87729. Please update any external references or bookmarks.