GNOME Bugzilla – Bug 86956
Too easy to set unmodified keys as bindings.
Last modified: 2006-01-22 11:55:00 UTC
I found it far too easy to set unmodified keys (such as 'space' and 'f') to be bound. I can imagine any of the `F*' keys being used unmodified, along with 'PrtSc', 'ScrLk', and 'Pause', but other than that, I think the potential for massive confusion is too great. My suggestions: Either (a) have a dialog come up when a user tries to give an unmodified letter key or (b) just give a beep when the user tries to give an unmodified letter key. Or perhaps (b) for the first time, then (a) if the user is being persistant. Also (a) could be done by printing a warning to the box the user expcts to see the shortcut show up in.
Yeah, good call, Ben.
SPAM as discussed last night. Search for 'SPAM as discussed last night' to catch these all and delete them. :)
This is a good idea. I'll commit a patch immediately after we branch
ping : does your patch still apply ?
any news on this ?
Jody: has sth been commited? I do not see an attached patch.
Asking the user would be a real bummer. It should be easy enough to blacklist, or whitelist a certain number of keys, but I'm afraid of causing problems for people that don't use latin-like keyboards.
Created attachment 57542 [details] [review] gcc-unmodified-keys.patch Example patch, the blacklisting needs to be much much chunkier obviously. This patch only reverts if any upper latin letter is typed on its own.
I can finish this patch off with what I think is right, and we could then wait for bug reports...
Please Bastien, finish the patch :)
Created attachment 57642 [details] [review] gcc-unmodified-keys-2.patch The dialogue, and its text probably suck a bit, would probably need HIG love as well. We refuse to bind main letter keys (or at least what I think are main letter keys) for: - Latin - Japanese - Arabic - Cyrillic - Greek - Hebrew - Thai - Korean/Hangul
the patch looks ok to me, if it works, so commit as you wish. I guess you'll have to warn translators about the string change though.
2006-01-22 Bastien Nocera <hadess@hadess.net> * gnome-keybinding-properties.c: (accel_edited_callback): Refuse to bind letter keys without a modifier (Closes: #86956) Only took 3.5 years to fix ;) bug 328152 asks for a better error message.