GNOME Bugzilla – Bug 85628
[ui-review] Background Preferences string changes
Last modified: 2004-12-22 21:47:04 UTC
The following issues came out of the recent ui-review and are recommended for fixing prior to GNOME 2.0.1: - Add seperator bar above the action area - Remove help text ("You can...")- it's in documentation - s/Picture/Select picture: - s/Color/Color: - s/Border the Picture with a/Picture border: - Picture border should be disabled if you select 'No picture' - Default button should be 'Close'
Adding keywords to all ui-review bugs in one mass change, sorry for the spam. It would be very nice if the folks doing UI review stuff would be sure to add 'PATCH' to the bugs that have those. I'm (tentatively) not marking these 'high' but the release team [having gotten approval from the docs and i18n people] would like to see these in ASAP on the 2.0.1 branches, so that i18n folks can start translating at their convenience.
- Lack of seperator was a bug. - done - s/_Picture/Select _picture:/ - done - s/C_olor/C_olor:/ s/_Left Color/_Left Color:/ s/_Right Color/_Right Color:/ s/_Top Color/_Top Color:/ s/_Bottom Color/_Bottom Color:/ - done - s/Bor_der the picture with a:/Picture Bor_der:/ - done - default button -> close - done The desensitization of the picture options is a bug. I'll fix. The other elements will need to be discussed.
Seth has explained the background colour sensitization logic and the current setup seems correct. No picture uses the colours to select the solid background. The colours are only desensitized when the background image covers the entire screen.
Adding a note about bug 83482, which should be at least looked at.
Also 76081.
After¦some¦discussion¦with¦the¦release¦team,¦in¦order¦to¦get¦these¦in¦to¦2.0.1 and¦to¦not¦make¦the¦translators¦shoot¦us,¦these¦need¦to¦get¦in¦ASAP¦:)¦I'm marking¦them¦'urgent'/2.0.1¦as¦a¦result;¦it¦would¦be¦greatly¦appreciated¦if maintainers¦of¦the¦affected¦components¦can¦work¦on¦getting¦these¦patched¦ASAP¦so that¦the¦translators¦can¦get¦cracking¦on¦them¦for¦the¦next¦release.¦[Subject,¦of course,¦to¦maintainer¦agreement¦with¦the¦goals¦of¦the¦review¦:)¦
[Search for 'luis spamming' to catch every instance of this email.] In order to better track Sun's bugs for Sun and Ximian's internal use, I've added a temporary keyword to some bugs. I apologize for the spam, and for the use of an additional keyword, but this is the best way for Sun to track 'it's' bugs without interfering with the community's own triage and bug behavior. If you have any questions or objections, please drop me a note at louie@ximian.com or email bugmaster@gnome.org for more open discussion.
After some discussion with bex and Eugene, we think this might be better: s/Picture Border:/Background Color: s/Solid Color/Solid Any objections/chance we could change it to this instead...? The problem with the current wording is that it's not really a "border" if you're not using a picture. (And changing the label dynamically depending on what picture option you had chosen would be kind of sucky for usability/accessibility).
The debate continues... Bex proposes: Background style and color: [Solid ] Color:[] Eugene proposes: +--Background Color----------------+ | | | Style: Solid Color: [=] | +----------------------------------+ I'm still trying to work out which I prefer :/
Best compromise I can think of at the moment would be something like: Background _Style: [Solid Color] _Color: [x] or if one of the other options were selected: Background _Style: [Horizontal gradient] _Left Color: [x] _Right Color: [y] Background _Style: [Vertical gradient] _Top Color: [x] _Bottom Color: [y]
*** Bug 87484 has been marked as a duplicate of this bug. ***
My goodness we've achieved consensus !
As far as I can see, the string I thought we were going to change to "Background Style" (according to the bug report) is still labelled "Picture Border", despite the "consensus" we reached... guess it's too late to re-open now though :/
Oops no, I take it back... was looking at the wrong revision in CVS. D'oh.
Docs updated to reflect these changes.
*** Bug 87239 has been marked as a duplicate of this bug. ***