GNOME Bugzilla – Bug 85216
Window_list is not updated in eog_window_destroy()
Last modified: 2009-08-15 18:40:50 UTC
The global window_list gets updated in eog_window_close(), not in eog_window_destroy() as it should. So, if you do gtk_widget_destroy(eog_window) from elsewhere in the program, EOG will still think that window is alive. This leads to a reproducible crash when killing the session.
*** Bug 84989 has been marked as a duplicate of this bug. ***
Created attachment 9209 [details] [review] Patch with proposed fix.
Fixed on CVS.
adding cc.. also tried to test this on build from 25th june - was unable to fully test due to a different gnome-session problem - see bug #86539
problem still present in nightly built from CVS 14th July - started eog in workspace 3, logged out, saved session, logged back in and no eog.
Problem still present in Solaris Intel 8 -source taken from '22nd july'.
Do you have a stack trace?
I don't know what there is to get a trace of? Just as gnome-terminal is not session aware so it seems EOG is not session aware. If I start EOG and the log out (saving session) when I log in EOG is not started. There is no session file for EOG in ~/.gnome2 BUT there is reference in the session file: 4,Program=eog 4,DiscardCommand=rm -f /export/home/gn_tst1/.gnome2/eog-UaaGfj/ 4,CloneCommand=eog --sm-config-prefix /eog-UaaGfj/ 4,RestartCommand=eog --sm-config-prefix /eog-UaaGfj/ --sm-client-id 11819cee11000102821237500000039080004 --screen 0 5,Program=eog 5,DiscardCommand=rm -f /export/home/gn_tst1/.gnome2/eog-1eaWfj/ 5,CloneCommand=eog --sm-config-prefix /eog-1eaWfj/ 5,RestartCommand=eog --sm-config-prefix /eog-1eaWfj/ --sm-client-id 11819cee11000102821238700000039080005 --screen 0 What does "4,DiscardCommand=rm -f /export/home/gn_tst1/.gnome2/eog-UaaGfj/" do?
Okay, let's do this step by step. 1. If EOG is crashing on exit or when the session ends, I need a trace of the 'eog' process. 2. I don't care about gnome-terminal as it is not relevant to this bug. 3. The DiscardCommand is what the session manager runs to remove the information for a program's saved session info. If EOG is not crashing but rather just not saving its session info, then you should not be putting this stuff on *this* bug. Open a new one or something.
ok i'll add this to a new bug but please remember that you're the one who closed bug #84989 as a duplicate of this bug :) I'll repoen #84989 and add info to it.