After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84987 - qp encoding doesn't work
qp encoding doesn't work
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.12.0 betas
Other Linux
: Normal normal
: 0.12.0
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-06-12 09:25 UTC by Martin Tomasek
Modified: 2006-06-18 05:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Martin Tomasek 2002-06-12 09:25:16 UTC
..for subjects like this:
Subject: =?iso-8859-2?Q?Re:_to_v=B9ichni_sp=EDte=3F?=
Comment 1 Charles Kerr 2002-06-12 15:25:09 UTC
Cc'ing Chris on this because he's usually the one to say
"hmm, I think that's an illegal encoding", and Fejj, because
he's usually the one to say "Charles and Chris, you bozos,
you're doing it wrong. You were *supposed* to do xyz..."

Honestly, the only thing I'm good for is pestering Chris and
Fejj with "have you fixed this charset encoding bug yet?"
and then saying "oh, I get it now" once I read the diff. :)
Comment 2 Jeffrey Stedfast 2002-06-12 18:26:32 UTC
from rfc2047:

   IMPORTANT: 'encoded-word's are designed to be recognized as 'atom's
   by an RFC 822 parser.

from rfc822, Appendix D:

     atom        =  1*<any CHAR except specials, SPACE and CTLs>

     specials    =  "(" / ")" / "<" / ">" / "@"  ; Must be in quoted-
                 /  "," / ";" / ":" / "\" / <">  ;  string, to use
                 /  "." / "[" / "]"              ;  within a word.

     word        =  atom / quoted-string
Comment 3 Christophe Lambin 2002-06-12 21:45:45 UTC
In plain English: 'This is an illegal encoding' :)   Specifically, the
colon shouldn't be there (not as a literal anyway).

We've been down this road before and the consensus was that we can't
address every non-compliant agent out there.
Comment 4 Martin Tomasek 2002-06-12 22:47:20 UTC
ok, so I looked over some header fields, which pan doesn't decode as 
author of specific news client meant. this one is afaik rfc compliant:

Subject: Re: !!! =?windows-1250?Q?Nab=EDz=EDm_scanov=E1n=ED_negativ=F9?=
 =?windows-1250?Q?=2C_p=F8edloh_do_A4=2C_=E8/b_lasertov=FD_ti?=
 =?windows-1250?Q?sk_a_=E8/b_inkoutov=FD_tisk_do_A2!!!?=

pan decodes only first line here (to the end of first =?widows-1250xyz?=)
Comment 5 Jeffrey Stedfast 2002-06-12 23:04:55 UTC
yea, it looks like it should be decoding. I'll take a look tonight
when I get home :-)
Comment 6 Jeffrey Stedfast 2002-06-13 01:51:26 UTC
looks like my gmime-utils.c:quoted_decode() function was a bit too
aggresive with erroring out. If it encountered a SPACE or ESPECIAL it
would abort. The check for ESPECIAL was wrong, since ESPECIALs are
actually allowed to be in the encoded-text section of an encoded-word
(rfc2047). The SPACE check was just plain redundant since our caller
does this, so I removed that whole else-if section.

this is now fixed in gmime-2, gmime-1 and pan HEAD

I also updated gmime-table-private.h since I found some problems with
it as well.

thanks for the bug report, otherwise I probably would never have
noticed ;-)