GNOME Bugzilla – Bug 84161
Workspace Switcher Applet Naming Oddity
Last modified: 2004-12-22 21:47:04 UTC
The workspace switcher applet has cleaned up its act a lot-- but I am still noticing some odd idiosyncracies with regard to workspace naming. Specifcally: When I try to assign names to multiple workspaces (I have tried this with 3, 4, 5 and 6 workspaces), the names I enter in the preferences dialog are all reflected in the applet EXCEPT the last name I entered. So if I open the preferences dialog and I name my workspaces "Anna", "Banana" and "Cabana", then after closing the dialog, I see "Anna", "Banana" and "Workspace 3". The same thing happens if I reverse the order and name Workspace 3 first-- in that case, I get "Workspace 1", "Banana", and "Cabana". This is, needless to say, annoying as hell. :) Just as I was about to close this bug I discovered something interesting. If I add a new workspace and give it a name (At this point, according to the preferences dialog I have: "Anna", "Banana", "Cabana", "Tropicana", and I added "Piranha"), then after closing the dialog, "Piranha" did not appear. However, upon reopening the dialog and clicking on another name in the list of workspace names, and then clicking "Close", all names appeared properly. Then again, I tried to reproduce this and couldn't.
Where do you come up with these names? :)
I can't reproduce this at all with latest code, Anna, and neither can anyone at wipro. Are you still seeing it?
Kalpesh is apparently able to duplicate this bug.
I was able to duplicate on build based on 1st june. But, I have yet to try on latest nightly build.
If this is a bug, then it is still present on 25th june's nightly build. But, IMHO then this is very LOW priority bug. OK, steps to reproduce: 1. First rule is never press "enter" key. 2. Go to preferences of workspace switcher. 3. Uncheck the "Show workspace names in the switcher". 4. With mouse, click on first name of workspace, and change it to say "a1". 5. With mouse click on second name of workspace, and change it to say "a2". 6. With mouse Click(Check) "Show workspace names in the switcher". What you see is that only first workspace gets the name a1, second doesn't change. Bug is if we move from the name changing field to other area, and click somewhere else, then the changed name should be accepted and registered. (like the first name was accepted). I hope I am clear. Else, let me know, I can explain again.
Created attachment 9500 [details] [review] Patch the fixes this odd problem of changing workspace name without button-press.
Created attachment 9588 [details] [review] Better hack than the one gave before :-)
Thanks Arvind. Committed the patch.
Just a clarification here. There is a basic problem with GtkTreeView updating the contents on a button press only. So the hack is to stop editing when you close the dialog and take those changes also for which the user did not do a button press. The names do not change immediately if go to another area of the dialog without hitting a button. They will be reflected on closing the dialog only. Hope this helps.